* [PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static
@ 2021-06-15 17:21 Wei Yongjun
2021-06-16 7:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
To: weiyongjun1, David S. Miller, Jakub Kicinski, Loic Poulain,
Manivannan Sadhasivam, Hemant Kumar,
Subash Abhinov Kasiviswanathan, Yang Yingliang
Cc: netdev, kernel-janitors, Hulk Robot
The sparse tool complains as follows:
drivers/net/mhi/net.c:385:23: warning:
symbol 'mhi_wwan_ops' was not declared. Should it be static?
This symbol is not used outside of net.c, so marks it static.
Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/mhi/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c
index 78d4a06fbeca..e5ec0d7510c8 100644
--- a/drivers/net/mhi/net.c
+++ b/drivers/net/mhi/net.c
@@ -382,7 +382,7 @@ static void mhi_net_dellink(void *ctxt, struct net_device *ndev,
dev_set_drvdata(&mhi_dev->dev, NULL);
}
-const struct wwan_ops mhi_wwan_ops = {
+static const struct wwan_ops mhi_wwan_ops = {
.owner = THIS_MODULE,
.priv_size = sizeof(struct mhi_net_dev),
.setup = mhi_net_setup,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static
2021-06-15 17:21 [PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static Wei Yongjun
@ 2021-06-16 7:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-16 7:40 UTC (permalink / raw)
To: Wei Yongjun
Cc: davem, kuba, loic.poulain, mani, hemantk, subashab,
yangyingliang, netdev, kernel-janitors, hulkci
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 15 Jun 2021 17:21:59 +0000 you wrote:
> The sparse tool complains as follows:
>
> drivers/net/mhi/net.c:385:23: warning:
> symbol 'mhi_wwan_ops' was not declared. Should it be static?
>
> This symbol is not used outside of net.c, so marks it static.
>
> [...]
Here is the summary with links:
- [net-next] net: mhi: Make symbol 'mhi_wwan_ops' static
https://git.kernel.org/netdev/net-next/c/1d0bbbf22b74
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 17:21 [PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static Wei Yongjun
2021-06-16 7:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).