* [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd
@ 2021-07-21 9:53 Colin King
2021-07-27 3:05 ` Martin K. Petersen
2021-07-29 3:38 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-07-21 9:53 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer pcmd is being initialized with a value that is never
read, the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_sli.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index c34240819d92..47dd13719901 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -10129,8 +10129,6 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq,
bf_set(wqe_ebde_cnt, &wqe->xmit_els_rsp.wqe_com, 0);
bf_set(wqe_rsp_temp_rpi, &wqe->xmit_els_rsp,
phba->sli4_hba.rpi_ids[ndlp->nlp_rpi]);
- pcmd = (uint32_t *) (((struct lpfc_dmabuf *)
- iocbq->context2)->virt);
if (phba->fc_topology == LPFC_TOPOLOGY_LOOP) {
bf_set(els_rsp64_sp, &wqe->xmit_els_rsp, 1);
bf_set(els_rsp64_sid, &wqe->xmit_els_rsp,
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd
2021-07-21 9:53 [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd Colin King
@ 2021-07-27 3:05 ` Martin K. Petersen
2021-07-29 3:38 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-07-27 3:05 UTC (permalink / raw)
To: Colin King
Cc: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
Colin,
> The pointer pcmd is being initialized with a value that is never read,
> the assignment is redundant and can be removed.
Applied to 5.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd
2021-07-21 9:53 [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd Colin King
2021-07-27 3:05 ` Martin K. Petersen
@ 2021-07-29 3:38 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-07-29 3:38 UTC (permalink / raw)
To: linux-scsi, Colin King, James E . J . Bottomley, Dick Kennedy,
James Smart
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Wed, 21 Jul 2021 10:53:50 +0100, Colin King wrote:
> The pointer pcmd is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
Applied to 5.15/scsi-queue, thanks!
[1/1] scsi: lpfc: remove redundant assignment to pointer pcmd
https://git.kernel.org/mkp/scsi/c/ff2d86d04d26
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-29 3:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 9:53 [PATCH] scsi: lpfc: remove redundant assignment to pointer pcmd Colin King
2021-07-27 3:05 ` Martin K. Petersen
2021-07-29 3:38 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).