kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: adjust selects for SM_VIDEOCC_8150 and SM_VIDEOCC_8250
@ 2021-08-16 13:59 Lukas Bulwahn
  2021-08-29  4:00 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-08-16 13:59 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	linux-arm-msm, linux-clk
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 5658e8cf1a8a ("clk: qcom: add video clock controller driver for
SM8150") and commit 0e94711a1f29 ("clk: qcom: add video clock controller
driver for SM8250") add config SM_VIDEOCC_8150 and config SM_VIDEOCC_8250,
which select the non-existing configs SDM_GCC_8150 and SDM_GCC_8250,
respectively.

Hence, ./scripts/checkkconfigsymbols.py warns:

SDM_GCC_8150
Referencing files: drivers/clk/qcom/Kconfig

SDM_GCC_8250
Referencing files: drivers/clk/qcom/Kconfig

It is probably just a typo (or naming confusion of using SM_GCC_xxx and
SDM_GCC_xxx for various Qualcomm clock drivers) in the config definitions
for config SM_VIDEOCC_8150 and SM_VIDEOCC_8250, and intends to select the
existing SM_GCC_8150 and SM_GCC_8250, respectively.

Adjust the selects to the existing configs.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/clk/qcom/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 85b090a8d9c6..6c54d810d615 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -579,7 +579,7 @@ config SM_GPUCC_8250
 
 config SM_VIDEOCC_8150
 	tristate "SM8150 Video Clock Controller"
-	select SDM_GCC_8150
+	select SM_GCC_8150
 	select QCOM_GDSC
 	help
 	  Support for the video clock controller on SM8150 devices.
@@ -588,7 +588,7 @@ config SM_VIDEOCC_8150
 
 config SM_VIDEOCC_8250
 	tristate "SM8250 Video Clock Controller"
-	select SDM_GCC_8250
+	select SM_GCC_8250
 	select QCOM_GDSC
 	help
 	  Support for the video clock controller on SM8250 devices.
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: qcom: adjust selects for SM_VIDEOCC_8150 and SM_VIDEOCC_8250
  2021-08-16 13:59 [PATCH] clk: qcom: adjust selects for SM_VIDEOCC_8150 and SM_VIDEOCC_8250 Lukas Bulwahn
@ 2021-08-29  4:00 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2021-08-29  4:00 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Lukas Bulwahn, Michael Turquette,
	linux-arm-msm, linux-clk
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Quoting Lukas Bulwahn (2021-08-16 06:59:30)
> Commit 5658e8cf1a8a ("clk: qcom: add video clock controller driver for
> SM8150") and commit 0e94711a1f29 ("clk: qcom: add video clock controller
> driver for SM8250") add config SM_VIDEOCC_8150 and config SM_VIDEOCC_8250,
> which select the non-existing configs SDM_GCC_8150 and SDM_GCC_8250,
> respectively.
> 
> Hence, ./scripts/checkkconfigsymbols.py warns:
> 
> SDM_GCC_8150
> Referencing files: drivers/clk/qcom/Kconfig
> 
> SDM_GCC_8250
> Referencing files: drivers/clk/qcom/Kconfig
> 
> It is probably just a typo (or naming confusion of using SM_GCC_xxx and
> SDM_GCC_xxx for various Qualcomm clock drivers) in the config definitions
> for config SM_VIDEOCC_8150 and SM_VIDEOCC_8250, and intends to select the
> existing SM_GCC_8150 and SM_GCC_8250, respectively.
> 
> Adjust the selects to the existing configs.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-29  4:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 13:59 [PATCH] clk: qcom: adjust selects for SM_VIDEOCC_8150 and SM_VIDEOCC_8250 Lukas Bulwahn
2021-08-29  4:00 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).