* [PATCH] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor()
@ 2021-10-13 7:53 Dan Carpenter
2021-10-13 22:41 ` Daniel Scally
2021-10-14 11:45 ` Kieran Bingham
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-10-13 7:53 UTC (permalink / raw)
To: Yong Zhi, Fabian Wüthrich
Cc: Sakari Ailus, Bingbu Cao, Dan Scally, Tianshu Qiu,
Mauro Carvalho Chehab, Andy Shevchenko, linux-media,
kernel-janitors
Return -ENODEV if acpi_get_physical_device_location() fails. Don't
return success.
Fixes: 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
index 67c467d3c81f..0b586b4e537e 100644
--- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
+++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
@@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
goto err_put_adev;
status = acpi_get_physical_device_location(adev->handle, &sensor->pld);
- if (ACPI_FAILURE(status))
+ if (ACPI_FAILURE(status)) {
+ ret = -ENODEV;
goto err_put_adev;
+ }
if (sensor->ssdb.lanes > CIO2_MAX_LANES) {
dev_err(&adev->dev,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor()
2021-10-13 7:53 [PATCH] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor() Dan Carpenter
@ 2021-10-13 22:41 ` Daniel Scally
2021-10-14 11:45 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Scally @ 2021-10-13 22:41 UTC (permalink / raw)
To: Dan Carpenter, Yong Zhi, Fabian Wüthrich
Cc: Sakari Ailus, Bingbu Cao, Tianshu Qiu, Mauro Carvalho Chehab,
Andy Shevchenko, linux-media, kernel-janitors
Hi Dan
On 13/10/2021 08:53, Dan Carpenter wrote:
> Return -ENODEV if acpi_get_physical_device_location() fails. Don't
> return success.
>
> Fixes: 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for catching that.
Reviewed-by: Daniel Scally <djrscally@gmail.com>
> ---
> drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> index 67c467d3c81f..0b586b4e537e 100644
> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> @@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
> goto err_put_adev;
>
> status = acpi_get_physical_device_location(adev->handle, &sensor->pld);
> - if (ACPI_FAILURE(status))
> + if (ACPI_FAILURE(status)) {
> + ret = -ENODEV;
> goto err_put_adev;
> + }
>
> if (sensor->ssdb.lanes > CIO2_MAX_LANES) {
> dev_err(&adev->dev,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor()
2021-10-13 7:53 [PATCH] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor() Dan Carpenter
2021-10-13 22:41 ` Daniel Scally
@ 2021-10-14 11:45 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-10-14 11:45 UTC (permalink / raw)
To: Dan Carpenter, Fabian Wüthrich, Yong Zhi
Cc: Sakari Ailus, Bingbu Cao, Dan Scally, Tianshu Qiu,
Mauro Carvalho Chehab, Andy Shevchenko, linux-media,
kernel-janitors
Quoting Dan Carpenter (2021-10-13 08:53:19)
> Return -ENODEV if acpi_get_physical_device_location() fails. Don't
> return success.
>
> Fixes: 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> index 67c467d3c81f..0b586b4e537e 100644
> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> @@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
> goto err_put_adev;
>
> status = acpi_get_physical_device_location(adev->handle, &sensor->pld);
> - if (ACPI_FAILURE(status))
> + if (ACPI_FAILURE(status)) {
> + ret = -ENODEV;
> goto err_put_adev;
> + }
>
> if (sensor->ssdb.lanes > CIO2_MAX_LANES) {
> dev_err(&adev->dev,
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-14 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 7:53 [PATCH] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor() Dan Carpenter
2021-10-13 22:41 ` Daniel Scally
2021-10-14 11:45 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).