kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
@ 2022-09-20  2:00 Sun Ke
  2022-09-22 10:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Sun Ke @ 2022-09-20  2:00 UTC (permalink / raw)
  To: joyce.ooi, davem, edumazet, kuba, pabeni, linux
  Cc: netdev, kernel-janitors, maxime.chevallier, sunke32

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sun Ke <sunke32@huawei.com>
---
 drivers/net/ethernet/altera/altera_tse_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 89ae6d1623aa..3cf409bdb283 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
 				       priv->phy_iface, &alt_tse_phylink_ops);
 	if (IS_ERR(priv->phylink)) {
 		dev_err(&pdev->dev, "failed to create phylink\n");
+		ret = PTR_ERR(priv->phylink);
 		goto err_init_phy;
 	}
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
  2022-09-20  2:00 [PATCH v3] net: ethernet: altera: TSE: fix error return code in altera_tse_probe() Sun Ke
@ 2022-09-22 10:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-22 10:30 UTC (permalink / raw)
  To: Sun Ke
  Cc: joyce.ooi, davem, edumazet, kuba, pabeni, linux, netdev,
	kernel-janitors, maxime.chevallier

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 20 Sep 2022 10:00:41 +0800 you wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> 
> [...]

Here is the summary with links:
  - [v3] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
    https://git.kernel.org/netdev/net-next/c/9b17dbd97de7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-22 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20  2:00 [PATCH v3] net: ethernet: altera: TSE: fix error return code in altera_tse_probe() Sun Ke
2022-09-22 10:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).