kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc
@ 2024-04-13 14:04 Christophe JAILLET
  2024-04-20  1:56 ` Stephen Boyd
  2024-04-21 16:07 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-04-13 14:04 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-arm-msm,
	linux-clk

In "struct rpm_cc", the 'rpm' field is unused.

Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring.
---
 drivers/clk/qcom/clk-rpm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index 745026ef4d9c..9da034f8f2ff 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b/drivers/clk/qcom/clk-rpm.c
@@ -98,7 +98,6 @@ struct clk_rpm {
 };
 
 struct rpm_cc {
-	struct qcom_rpm *rpm;
 	struct clk_rpm **clks;
 	size_t num_clks;
 	u32 xo_buffer_value;
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc
  2024-04-13 14:04 [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc Christophe JAILLET
@ 2024-04-20  1:56 ` Stephen Boyd
  2024-04-21 16:07 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2024-04-20  1:56 UTC (permalink / raw)
  To: Bjorn Andersson, Christophe JAILLET, Michael Turquette
  Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-arm-msm,
	linux-clk

Quoting Christophe JAILLET (2024-04-13 07:04:04)
> In "struct rpm_cc", the 'rpm' field is unused.
> 
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc
  2024-04-13 14:04 [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc Christophe JAILLET
  2024-04-20  1:56 ` Stephen Boyd
@ 2024-04-21 16:07 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-04-21 16:07 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Christophe JAILLET
  Cc: linux-kernel, kernel-janitors, linux-arm-msm, linux-clk


On Sat, 13 Apr 2024 16:04:04 +0200, Christophe JAILLET wrote:
> In "struct rpm_cc", the 'rpm' field is unused.
> 
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: rpm: Remove an unused field in struct rpm_cc
      commit: 3cb55215479f04940240792479c60fad53c2d202

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-21 16:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-13 14:04 [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc Christophe JAILLET
2024-04-20  1:56 ` Stephen Boyd
2024-04-21 16:07 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).