* [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short
@ 2017-11-07 14:31 Colin King
2017-11-07 14:32 ` NAK: " Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-07 14:31 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed. Cleans up clang warning:
drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
to 'dev' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index 14606f340325..e3d362cc47db 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -984,8 +984,6 @@ static int write_fifo(struct pxa_ep *ep, struct pxa27x_request *req)
max = ep->fifo_size;
do {
- is_short = 0;
-
udccsr = udc_ep_readl(ep, UDCCSR);
if (udccsr & UDCCSR_PC) {
ep_vdbg(ep, "Clearing Transmit Complete, udccsr=%x\n",
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* NAK: [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short
2017-11-07 14:31 [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short Colin King
@ 2017-11-07 14:32 ` Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2017-11-07 14:32 UTC (permalink / raw)
To: linux-arm-kernel
On 07/11/17 14:31, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed. Cleans up clang warning:
>
> drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
> to 'dev' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/gadget/udc/pxa27x_udc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
> index 14606f340325..e3d362cc47db 100644
> --- a/drivers/usb/gadget/udc/pxa27x_udc.c
> +++ b/drivers/usb/gadget/udc/pxa27x_udc.c
> @@ -984,8 +984,6 @@ static int write_fifo(struct pxa_ep *ep, struct pxa27x_request *req)
>
> max = ep->fifo_size;
> do {
> - is_short = 0;
> -
> udccsr = udc_ep_readl(ep, UDCCSR);
> if (udccsr & UDCCSR_PC) {
> ep_vdbg(ep, "Clearing Transmit Complete, udccsr=%x\n",
>
Ignore this, sorry. It's wrong
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-07 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 14:31 [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short Colin King
2017-11-07 14:32 ` NAK: " Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).