* [PATCH] drm/amdgpu: remove redundant assignment of variable k
@ 2021-06-03 12:34 Colin King
2021-06-03 15:22 ` Felix Kuehling
2021-06-04 7:52 ` Christian König
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-06-03 12:34 UTC (permalink / raw)
To: Felix Kuehling, Alex Deucher, Christian König, Xinhui.Pan,
David Airlie, Daniel Vetter, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable k is being assigned a value that is never read, the
assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index 2a7bed66d50b..f545dc1248b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -278,7 +278,7 @@ static int amdgpu_amdkfd_remove_eviction_fence(struct amdgpu_bo *bo,
write_seqcount_end(&resv->seq);
/* Drop the references to the removed fences or move them to ef_list */
- for (i = j, k = 0; i < old->shared_count; ++i) {
+ for (i = j; i < old->shared_count; ++i) {
struct dma_fence *f;
f = rcu_dereference_protected(new->shared[i],
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: remove redundant assignment of variable k
2021-06-03 12:34 [PATCH] drm/amdgpu: remove redundant assignment of variable k Colin King
@ 2021-06-03 15:22 ` Felix Kuehling
2021-06-04 7:52 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Felix Kuehling @ 2021-06-03 15:22 UTC (permalink / raw)
To: Colin King, Alex Deucher, Christian König, Xinhui.Pan,
David Airlie, Daniel Vetter, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Am 2021-06-03 um 8:34 a.m. schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable k is being assigned a value that is never read, the
> assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I'm applying the patch to amd-staging-drm-next.
Thanks,
Felix
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 2a7bed66d50b..f545dc1248b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -278,7 +278,7 @@ static int amdgpu_amdkfd_remove_eviction_fence(struct amdgpu_bo *bo,
> write_seqcount_end(&resv->seq);
>
> /* Drop the references to the removed fences or move them to ef_list */
> - for (i = j, k = 0; i < old->shared_count; ++i) {
> + for (i = j; i < old->shared_count; ++i) {
> struct dma_fence *f;
>
> f = rcu_dereference_protected(new->shared[i],
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: remove redundant assignment of variable k
2021-06-03 12:34 [PATCH] drm/amdgpu: remove redundant assignment of variable k Colin King
2021-06-03 15:22 ` Felix Kuehling
@ 2021-06-04 7:52 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2021-06-04 7:52 UTC (permalink / raw)
To: Colin King, Felix Kuehling, Alex Deucher, Xinhui.Pan,
David Airlie, Daniel Vetter, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Am 03.06.21 um 14:34 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable k is being assigned a value that is never read, the
> assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 2a7bed66d50b..f545dc1248b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -278,7 +278,7 @@ static int amdgpu_amdkfd_remove_eviction_fence(struct amdgpu_bo *bo,
> write_seqcount_end(&resv->seq);
>
> /* Drop the references to the removed fences or move them to ef_list */
> - for (i = j, k = 0; i < old->shared_count; ++i) {
> + for (i = j; i < old->shared_count; ++i) {
> struct dma_fence *f;
>
> f = rcu_dereference_protected(new->shared[i],
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 12:34 [PATCH] drm/amdgpu: remove redundant assignment of variable k Colin King
2021-06-03 15:22 ` Felix Kuehling
2021-06-04 7:52 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).