* [patch -next] qlogic: qed: fix a test for MODE_MF_SI
@ 2015-11-04 13:29 Dan Carpenter
2015-11-04 13:35 ` Yuval Mintz
2015-11-05 3:06 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-11-04 13:29 UTC (permalink / raw)
To: Yuval Mintz; +Cc: Ariel Elior, everest-linux-l2, netdev, kernel-janitors
MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9.
Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index b9b7b7e..774b223 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -562,7 +562,7 @@ static int qed_hw_init_pf(struct qed_hwfn *p_hwfn,
}
/* Enable classification by MAC if needed */
- if (hw_mode & MODE_MF_SI) {
+ if (hw_mode & (1 << MODE_MF_SI)) {
DP_VERBOSE(p_hwfn, NETIF_MSG_HW,
"Configuring TAGMAC_CLS_TYPE\n");
STORE_RT_REG(p_hwfn,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch -next] qlogic: qed: fix a test for MODE_MF_SI
2015-11-04 13:29 [patch -next] qlogic: qed: fix a test for MODE_MF_SI Dan Carpenter
@ 2015-11-04 13:35 ` Yuval Mintz
2015-11-05 3:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Mintz @ 2015-11-04 13:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ariel Elior, Dept-Eng Everest Linux L2, netdev, kernel-janitors
> MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9.
>
> Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
True indeed. Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch -next] qlogic: qed: fix a test for MODE_MF_SI
2015-11-04 13:29 [patch -next] qlogic: qed: fix a test for MODE_MF_SI Dan Carpenter
2015-11-04 13:35 ` Yuval Mintz
@ 2015-11-05 3:06 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-11-05 3:06 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 4 Nov 2015 16:29:11 +0300
> MODE_MF_SI is 9. We should be testing bit 9 instead of AND 0x9.
>
> Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-05 3:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-04 13:29 [patch -next] qlogic: qed: fix a test for MODE_MF_SI Dan Carpenter
2015-11-04 13:35 ` Yuval Mintz
2015-11-05 3:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).