* [PATCH] usb: host: fix incorrect updating of offset
@ 2017-11-07 16:45 Colin King
2017-11-07 17:39 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-07 16:45 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable temp is incorrectly being updated, instead it should
be offset otherwise the loop just reads the same capability value
and loops forever. Thanks to Alan Stern for pointing out the
correct fix to my original fix. Fix also cleans up clang warning:
drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
is never read
Fixes: d49d43174400 ("USB: misc ehci updates")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 7fb21d01b3d0..3bd0b2273171 100644
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -838,7 +838,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
default: /* unknown */
break;
}
- temp = (cap >> 8) & 0xff;
+ offset = (cap >> 8) & 0xff;
}
}
#endif
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: host: fix incorrect updating of offset
2017-11-07 16:45 [PATCH] usb: host: fix incorrect updating of offset Colin King
@ 2017-11-07 17:39 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2017-11-07 17:39 UTC (permalink / raw)
To: Colin King; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-kernel
On Tue, 7 Nov 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable temp is incorrectly being updated, instead it should
> be offset otherwise the loop just reads the same capability value
> and loops forever. Thanks to Alan Stern for pointing out the
> correct fix to my original fix. Fix also cleans up clang warning:
>
> drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
> is never read
>
> Fixes: d49d43174400 ("USB: misc ehci updates")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/host/ehci-dbg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
> index 7fb21d01b3d0..3bd0b2273171 100644
> --- a/drivers/usb/host/ehci-dbg.c
> +++ b/drivers/usb/host/ehci-dbg.c
> @@ -838,7 +838,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
> default: /* unknown */
> break;
> }
> - temp = (cap >> 8) & 0xff;
> + offset = (cap >> 8) & 0xff;
> }
> }
> #endif
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-07 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 16:45 [PATCH] usb: host: fix incorrect updating of offset Colin King
2017-11-07 17:39 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).