* [PATCH] PCI: ibmphp: fix get_max_bus_speed()
@ 2018-04-19 10:05 Dan Carpenter
2018-04-30 21:04 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-04-19 10:05 UTC (permalink / raw)
To: Bjorn Helgaas, Matthew Wilcox
Cc: Arvind Yadav, Sinan Kaya, Greg Kroah-Hartman, linux-pci, kernel-janitors
The "rc" variable is only initialized on the error path. The caller
doesn't check the return but, if "rc" is non-zero, then this function is
basically a no-op.
Fixes: 3749c51ac6c1 ("PCI: Make current and maximum bus speeds part of the PCI core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index b81ca3fa0e84..1869b0411ce0 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -379,7 +379,7 @@ static int get_adapter_present(struct hotplug_slot *hotplug_slot, u8 *value)
static int get_max_bus_speed(struct slot *slot)
{
- int rc;
+ int rc = 0;
u8 mode = 0;
enum pci_bus_speed speed;
struct pci_bus *bus = slot->hotplug_slot->pci_slot->bus;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: ibmphp: fix get_max_bus_speed()
2018-04-19 10:05 [PATCH] PCI: ibmphp: fix get_max_bus_speed() Dan Carpenter
@ 2018-04-30 21:04 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2018-04-30 21:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Bjorn Helgaas, Matthew Wilcox, Arvind Yadav, Sinan Kaya,
Greg Kroah-Hartman, linux-pci, kernel-janitors
On Thu, Apr 19, 2018 at 01:05:49PM +0300, Dan Carpenter wrote:
> The "rc" variable is only initialized on the error path. The caller
> doesn't check the return but, if "rc" is non-zero, then this function is
> basically a no-op.
>
> Fixes: 3749c51ac6c1 ("PCI: Make current and maximum bus speeds part of the PCI core")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to pci/hotplug for v4.18, thanks!
> diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
> index b81ca3fa0e84..1869b0411ce0 100644
> --- a/drivers/pci/hotplug/ibmphp_core.c
> +++ b/drivers/pci/hotplug/ibmphp_core.c
> @@ -379,7 +379,7 @@ static int get_adapter_present(struct hotplug_slot *hotplug_slot, u8 *value)
>
> static int get_max_bus_speed(struct slot *slot)
> {
> - int rc;
> + int rc = 0;
> u8 mode = 0;
> enum pci_bus_speed speed;
> struct pci_bus *bus = slot->hotplug_slot->pci_slot->bus;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-30 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 10:05 [PATCH] PCI: ibmphp: fix get_max_bus_speed() Dan Carpenter
2018-04-30 21:04 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).