[PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()

[PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()

[YueHaibing]

From: Yue Haibing <yuehaibing@huawei.com>

There is no need to have the 'struct se_portal_group *tpg' variable
static since new value always be assigned before use it.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 1ae638b..fe02fab 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -3602,7 +3602,7 @@ static struct se_portal_group *srpt_make_tpg(struct se_wwn *wwn,
 					     const char *name)
 {
 	struct srpt_port *sport = wwn->priv;
-	static struct se_portal_group *tpg;
+	struct se_portal_group *tpg;
 	int res;
 
 	WARN_ON_ONCE(wwn != &sport->port_guid_wwn &&

Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

On Thu, Nov 15, 2018 at 10:55:00AM +0000, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()

[Bart Van Assche]

On 11/15/18 2:55 AM, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> 
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()

[Jason Gunthorpe]

On Thu, Nov 15, 2018 at 10:55:00AM +0000, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> 
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next

Thanks,
Jason