* [PATCH] mmc: alcor: remove a redundant greater or equal to zero comparison
@ 2019-07-01 17:52 Colin King
2019-07-08 11:55 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-07-01 17:52 UTC (permalink / raw)
To: Ulf Hansson, Daniel Drake, linux-mmc; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A greater or equal comparison on the unsigned int variable tmp_diff
is always true as unsigned ints are never negative. Hence the
comparison is redundant and can be removed.
Addresses-Coverity: ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mmc/host/alcor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c
index e481535cba2b..1aee485d56d4 100644
--- a/drivers/mmc/host/alcor.c
+++ b/drivers/mmc/host/alcor.c
@@ -672,7 +672,7 @@ static void alcor_set_clock(struct alcor_sdmmc_host *host, unsigned int clock)
tmp_clock = DIV_ROUND_UP(cfg->clk_src_freq, tmp_div);
tmp_diff = abs(clock - tmp_clock);
- if (tmp_diff >= 0 && tmp_diff < diff) {
+ if (tmp_diff < diff) {
diff = tmp_diff;
clk_src = cfg->clk_src_reg;
clk_div = tmp_div;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: alcor: remove a redundant greater or equal to zero comparison
2019-07-01 17:52 [PATCH] mmc: alcor: remove a redundant greater or equal to zero comparison Colin King
@ 2019-07-08 11:55 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-07-08 11:55 UTC (permalink / raw)
To: Colin King
Cc: Daniel Drake, linux-mmc, kernel-janitors, Linux Kernel Mailing List
On Mon, 1 Jul 2019 at 19:52, Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> A greater or equal comparison on the unsigned int variable tmp_diff
> is always true as unsigned ints are never negative. Hence the
> comparison is redundant and can be removed.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/alcor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c
> index e481535cba2b..1aee485d56d4 100644
> --- a/drivers/mmc/host/alcor.c
> +++ b/drivers/mmc/host/alcor.c
> @@ -672,7 +672,7 @@ static void alcor_set_clock(struct alcor_sdmmc_host *host, unsigned int clock)
> tmp_clock = DIV_ROUND_UP(cfg->clk_src_freq, tmp_div);
> tmp_diff = abs(clock - tmp_clock);
>
> - if (tmp_diff >= 0 && tmp_diff < diff) {
> + if (tmp_diff < diff) {
> diff = tmp_diff;
> clk_src = cfg->clk_src_reg;
> clk_div = tmp_div;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 17:52 [PATCH] mmc: alcor: remove a redundant greater or equal to zero comparison Colin King
2019-07-08 11:55 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).