* [PATCH] iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()'
@ 2020-04-26 19:44 Christophe JAILLET
2020-05-02 18:17 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-04-26 19:44 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, maitysanchayan, robh
Cc: linux-iio, linux-kernel, kernel-janitors, Christophe JAILLET
A call to 'vf610_dac_exit()' is missing in an error handling path.
Fixes: 1b983bf42fad ("iio: dac: vf610_dac: Add IIO DAC driver for Vybrid SoC")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Un-tested.
Proposal based on function names and functions called in the remove function
---
drivers/iio/dac/vf610_dac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c
index 71f8a5c471c4..7f1e9317c3f3 100644
--- a/drivers/iio/dac/vf610_dac.c
+++ b/drivers/iio/dac/vf610_dac.c
@@ -223,6 +223,7 @@ static int vf610_dac_probe(struct platform_device *pdev)
return 0;
error_iio_device_register:
+ vf610_dac_exit(info);
clk_disable_unprepare(info->clk);
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()'
2020-04-26 19:44 [PATCH] iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' Christophe JAILLET
@ 2020-05-02 18:17 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-05-02 18:17 UTC (permalink / raw)
To: Christophe JAILLET
Cc: knaack.h, lars, pmeerw, maitysanchayan, robh, linux-iio,
linux-kernel, kernel-janitors
On Sun, 26 Apr 2020 21:44:03 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> A call to 'vf610_dac_exit()' is missing in an error handling path.
>
> Fixes: 1b983bf42fad ("iio: dac: vf610_dac: Add IIO DAC driver for Vybrid SoC")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
I'll count this one as 'obviously' correct, though happy to have input
from sanchayan if possible.
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> Un-tested.
> Proposal based on function names and functions called in the remove function
> ---
> drivers/iio/dac/vf610_dac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c
> index 71f8a5c471c4..7f1e9317c3f3 100644
> --- a/drivers/iio/dac/vf610_dac.c
> +++ b/drivers/iio/dac/vf610_dac.c
> @@ -223,6 +223,7 @@ static int vf610_dac_probe(struct platform_device *pdev)
> return 0;
>
> error_iio_device_register:
> + vf610_dac_exit(info);
> clk_disable_unprepare(info->clk);
>
> return ret;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-02 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 19:44 [PATCH] iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' Christophe JAILLET
2020-05-02 18:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).