* [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues_uld()
@ 2020-05-28 12:49 Dan Carpenter
2020-06-01 18:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-05-28 12:49 UTC (permalink / raw)
To: Vishal Kulkarni; +Cc: David S. Miller, Jakub Kicinski, netdev, kernel-janitors
The caller doesn't care about the error codes, they only check for zero
vs non-zero. Still, it's better to preserve the negative error codes
from alloc_uld_rxqs() instead of changing it to 1. We can also return
directly if there is a failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This isn't a bugfix so it should probably go to net-next, but the code
is pretty old.
The other error handling only checks the last iteration in the
for_each_port() loop. I didn't change that because it's slightly
riskier and I can't test the code.
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 6b1d3df4b9bae..9e3c6b36cde89 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -174,13 +174,14 @@ static int
setup_sge_queues_uld(struct adapter *adap, unsigned int uld_type, bool lro)
{
struct sge_uld_rxq_info *rxq_info = adap->sge.uld_rxq_info[uld_type];
- int i, ret = 0;
+ int i, ret;
- ret = !(!alloc_uld_rxqs(adap, rxq_info, lro));
+ ret = alloc_uld_rxqs(adap, rxq_info, lro);
+ if (ret)
+ return ret;
/* Tell uP to route control queue completions to rdma rspq */
- if (adap->flags & CXGB4_FULL_INIT_DONE &&
- !ret && uld_type = CXGB4_ULD_RDMA) {
+ if (adap->flags & CXGB4_FULL_INIT_DONE && uld_type = CXGB4_ULD_RDMA) {
struct sge *s = &adap->sge;
unsigned int cmplqid;
u32 param, cmdop;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues_uld()
2020-05-28 12:49 [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues_uld() Dan Carpenter
@ 2020-06-01 18:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-01 18:33 UTC (permalink / raw)
To: dan.carpenter; +Cc: vishal, kuba, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 28 May 2020 15:49:57 +0300
> The caller doesn't care about the error codes, they only check for zero
> vs non-zero. Still, it's better to preserve the negative error codes
> from alloc_uld_rxqs() instead of changing it to 1. We can also return
> directly if there is a failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-01 18:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 12:49 [PATCH net-next] cxgb4: cleanup error code in setup_sge_queues_uld() Dan Carpenter
2020-06-01 18:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).