* [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
@ 2020-06-24 10:13 Colin King
2020-06-24 21:57 ` David Miller
2020-06-25 16:32 ` [EXT] " Igor Russkikh
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-06-24 10:13 UTC (permalink / raw)
To: Ariel Elior, GR-everest-linux-l2, David S . Miller,
Jakub Kicinski, Michal Kalderon, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
enum dbg_status however there is a missing corresponding entry for
this in the array s_status_str. This causes an out-of-bounds read when
indexing into the last entry of s_status_str. Fix this by adding in
the missing entry.
Addresses-Coverity: ("Out-of-bounds read").
Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c
index 57a0dab88431..81e8fbe4a05b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
@@ -5568,7 +5568,8 @@ static const char * const s_status_str[] = {
/* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
"The filter/trigger constraint dword offsets are not enabled for recording",
-
+ /* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
+ "No matching framing mode",
/* DBG_STATUS_VFC_READ_ERROR */
"Error reading from VFC",
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
2020-06-24 10:13 [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE Colin King
@ 2020-06-24 21:57 ` David Miller
2020-06-25 16:32 ` [EXT] " Igor Russkikh
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-24 21:57 UTC (permalink / raw)
To: colin.king
Cc: aelior, GR-everest-linux-l2, kuba, michal.kalderon, netdev,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 24 Jun 2020 11:13:02 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
> enum dbg_status however there is a missing corresponding entry for
> this in the array s_status_str. This causes an out-of-bounds read when
> indexing into the last entry of s_status_str. Fix this by adding in
> the missing entry.
>
> Addresses-Coverity: ("Out-of-bounds read").
> Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EXT] [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
2020-06-24 10:13 [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE Colin King
2020-06-24 21:57 ` David Miller
@ 2020-06-25 16:32 ` Igor Russkikh
1 sibling, 0 replies; 3+ messages in thread
From: Igor Russkikh @ 2020-06-25 16:32 UTC (permalink / raw)
To: Colin King, Ariel Elior, GR-everest-linux-l2, David S . Miller,
Jakub Kicinski, Michal Kalderon, netdev
Cc: kernel-janitors, linux-kernel
Hi Colin!
Thanks for catching this, indeed this was missed!
>
> /* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
> "The filter/trigger constraint dword offsets are not enabled for
> recording",
> -
> + /* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
> + "No matching framing mode",
>
Could you please however change the string to
"No matching framing mode found for the enabled blocks/Storms - use less
dwords for blocks data",
If you don't have much time, I can repost this for you. With this change it'll
be in sync with our internal error descriptions.
Thanks
Igor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-25 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 10:13 [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE Colin King
2020-06-24 21:57 ` David Miller
2020-06-25 16:32 ` [EXT] " Igor Russkikh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).