archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
To: Markus Elfring <>
Cc: Felipe Balbi <>,,,,
	Matthias Brugger <>,,
	Chunfeng Yun <>,
	Colin Ian King <>,
Subject: Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference
Date: Mon, 29 Jun 2020 08:10:39 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Jun 29, 2020 at 10:00:22AM +0200, Markus Elfring wrote:
> > Some pointers are dereferenced before successful checks.
> I suggest to reconsider and improve the change description.
> * Would a null pointer dereference be possible only with the variables “mep”
>   and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?
> * How do you think about to adjust any more variable initialisations?
> * Will it become helpful to add the tag “Fixes” to the commit message?
> Regards,
> Markus


This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.


greg k-h's patch email bot

  reply	other threads:[~2020-06-29  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2020-06-29  7:30 ` [PATCH 1/2] usb: mtu3: disable USB2 LPM Markus Elfring
2020-06-29  8:10   ` Greg Kroah-Hartman
     [not found] ` <>
2020-06-29  8:00   ` [PATCH 2/2] usb: mtu3: fix NULL pointer dereference Markus Elfring
2020-06-29  8:10     ` Greg Kroah-Hartman [this message]
2020-06-30  7:28     ` Chunfeng Yun
2020-06-29 16:19   ` Searching for initialisation of variables by function calls before null pointer checks Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).