archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Chunfeng Yun <>,
	Greg Kroah-Hartman <>,
	Felipe Balbi <>,
	Matthias Brugger <>,,,
Cc: Colin Ian King <>,,
Subject: Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference
Date: Mon, 29 Jun 2020 08:00:22 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> Some pointers are dereferenced before successful checks.

I suggest to reconsider and improve the change description.

* Would a null pointer dereference be possible only with the variables “mep”
  and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?

* How do you think about to adjust any more variable initialisations?

* Will it become helpful to add the tag “Fixes” to the commit message?


  parent reply	other threads:[~2020-06-29  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2020-06-29  7:30 ` [PATCH 1/2] usb: mtu3: disable USB2 LPM Markus Elfring
2020-06-29  8:10   ` Greg Kroah-Hartman
     [not found] ` <>
2020-06-29  8:00   ` Markus Elfring [this message]
2020-06-29  8:10     ` [PATCH 2/2] usb: mtu3: fix NULL pointer dereference Greg Kroah-Hartman
2020-06-30  7:28     ` Chunfeng Yun
2020-06-29 16:19   ` Searching for initialisation of variables by function calls before null pointer checks Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).