* [PATCH][next] scsi: lpfc: fix less than zero comparison on unsigned int computation
@ 2020-07-06 13:08 Colin King
2020-07-06 14:48 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-07-06 13:08 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The expressions start_idx - dbg_cnt is evaluated using unsigned int
arthithmetic (since these variables are unsigned ints) and hence can
never be less than zero, so the less than comparison is never true.
Re-write the expression to check for start_idx being less than dbg_cnt.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 7285b0114837..ce5afe7b11d0 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
} else {
- if ((start_idx - dbg_cnt) < 0) {
+ if (start_idx < dbg_cnt) {
start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
temp_idx = 0;
} else {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] scsi: lpfc: fix less than zero comparison on unsigned int computation
2020-07-06 13:08 [PATCH][next] scsi: lpfc: fix less than zero comparison on unsigned int computation Colin King
@ 2020-07-06 14:48 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2020-07-06 14:48 UTC (permalink / raw)
To: Colin King, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
On 7/6/2020 6:08 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The expressions start_idx - dbg_cnt is evaluated using unsigned int
> arthithmetic (since these variables are unsigned ints) and hence can
> never be less than zero, so the less than comparison is never true.
> Re-write the expression to check for start_idx being less than dbg_cnt.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 7285b0114837..ce5afe7b11d0 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
> if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
> temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
> } else {
> - if ((start_idx - dbg_cnt) < 0) {
> + if (start_idx < dbg_cnt) {
> start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
> temp_idx = 0;
> } else {
Thanks Colin - I was about to send a patch for this. Has this fix and
one a couple of lines further down. I will post it shortly.
-- james
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-06 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 13:08 [PATCH][next] scsi: lpfc: fix less than zero comparison on unsigned int computation Colin King
2020-07-06 14:48 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).