* [PATCH] media: allegro: fix an error pointer vs NULL check
@ 2020-07-22 12:38 Dan Carpenter
2020-07-22 13:04 ` Michael Tretter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-07-22 12:38 UTC (permalink / raw)
To: Michael Tretter
Cc: devel, kernel-janitors, Pengutronix Kernel Team, Hans Verkuil,
Mauro Carvalho Chehab, linux-media
The allegro_mbox_init() function returns error pointers, it never
returns NULL.
Fixes: 94dc76560261 ("media: allegro: rework mbox handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/staging/media/allegro-dvt/allegro-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro-dvt/allegro-core.c
index 61beae1fca36..9f718f43282b 100644
--- a/drivers/staging/media/allegro-dvt/allegro-core.c
+++ b/drivers/staging/media/allegro-dvt/allegro-core.c
@@ -2952,7 +2952,7 @@ static int allegro_mcu_hw_init(struct allegro_dev *dev,
info->mailbox_size);
dev->mbox_status = allegro_mbox_init(dev, info->mailbox_status,
info->mailbox_size);
- if (!dev->mbox_command || !dev->mbox_status) {
+ if (IS_ERR(dev->mbox_command) || IS_ERR(dev->mbox_status)) {
v4l2_err(&dev->v4l2_dev,
"failed to initialize mailboxes\n");
return -EIO;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: allegro: fix an error pointer vs NULL check
2020-07-22 12:38 [PATCH] media: allegro: fix an error pointer vs NULL check Dan Carpenter
@ 2020-07-22 13:04 ` Michael Tretter
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tretter @ 2020-07-22 13:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: devel, kernel-janitors, Pengutronix Kernel Team, Hans Verkuil,
Mauro Carvalho Chehab, linux-media
On Wed, 22 Jul 2020 15:38:48 +0300, Dan Carpenter wrote:
> The allegro_mbox_init() function returns error pointers, it never
> returns NULL.
>
> Fixes: 94dc76560261 ("media: allegro: rework mbox handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> drivers/staging/media/allegro-dvt/allegro-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro-dvt/allegro-core.c
> index 61beae1fca36..9f718f43282b 100644
> --- a/drivers/staging/media/allegro-dvt/allegro-core.c
> +++ b/drivers/staging/media/allegro-dvt/allegro-core.c
> @@ -2952,7 +2952,7 @@ static int allegro_mcu_hw_init(struct allegro_dev *dev,
> info->mailbox_size);
> dev->mbox_status = allegro_mbox_init(dev, info->mailbox_status,
> info->mailbox_size);
> - if (!dev->mbox_command || !dev->mbox_status) {
> + if (IS_ERR(dev->mbox_command) || IS_ERR(dev->mbox_status)) {
> v4l2_err(&dev->v4l2_dev,
> "failed to initialize mailboxes\n");
> return -EIO;
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-22 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 12:38 [PATCH] media: allegro: fix an error pointer vs NULL check Dan Carpenter
2020-07-22 13:04 ` Michael Tretter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).