kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] USB: PHY: JZ4770: Fix static checker warning
       [not found] <96687bd5-aa10-b908-471a-31e8daa01472@web.de>
@ 2020-08-25 10:00 ` Greg Kroah-Hartman
  0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2020-08-25 10:00 UTC (permalink / raw)
  To: Markus Elfring
  Cc: 周琰杰,
	linux-usb, linux-kernel, kernel-janitors, Dongsheng Qiu,
	Felipe Balbi, qipengzhen, Rick Tyliu, Yanfei Li, zhenwenjin,
	周正

On Tue, Aug 25, 2020 at 11:35:16AM +0200, Markus Elfring wrote:
> > The commit 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new
> > Ingenic SoCs.") introduced the initialization function for different
> > chips, but left the relevant code involved in the resetting process
> > in the original function, resulting in uninitialized variable calls.
> 
> * Can another imperative wording be helpful for the change description?
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idÐ12a7190fc1fd72ed48911e77ca97ba4521bccd#n151
> 
> * How do you think about to mention any source code analysis tool here?
> 
> * Would an other commit subject be more appropriate?
> 
> 
> > Fixes: 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new
> > Ingenic SoCs.").
> 
> Please omit a line break for this tag.
> 
> 
> I find that a single patch would not need a cover letter.

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-25 10:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <96687bd5-aa10-b908-471a-31e8daa01472@web.de>
2020-08-25 10:00 ` [PATCH] USB: PHY: JZ4770: Fix static checker warning Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).