* [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()
@ 2020-09-11 11:34 Dan Carpenter
2020-09-11 12:11 ` [Intel-gfx] " Andi Shyti
2020-09-11 13:02 ` Tvrtko Ursulin
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-09-11 11:34 UTC (permalink / raw)
To: Jani Nikula
Cc: kernel-janitors, David Airlie, intel-gfx, Chris Wilson,
Thomas Hellström, Matthew Auld
There is a copy and paste error here. The "obj" should be "obj2". The
current code could result in an Oops.
Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/i915/selftests/i915_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
index 23a6132c5f4e..412e21604a05 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
@@ -211,8 +211,8 @@ static int igt_gem_ww_ctx(void *arg)
return PTR_ERR(obj);
obj2 = i915_gem_object_create_internal(i915, PAGE_SIZE);
- if (IS_ERR(obj)) {
- err = PTR_ERR(obj);
+ if (IS_ERR(obj2)) {
+ err = PTR_ERR(obj2);
goto put1;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()
2020-09-11 11:34 [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() Dan Carpenter
@ 2020-09-11 12:11 ` Andi Shyti
2020-09-11 13:02 ` Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2020-09-11 12:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, intel-gfx, kernel-janitors, Chris Wilson,
Thomas Hellström, Matthew Auld
Hi Dan,
> There is a copy and paste error here. The "obj" should be "obj2". The
> current code could result in an Oops.
>
> Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
> index 23a6132c5f4e..412e21604a05 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
> @@ -211,8 +211,8 @@ static int igt_gem_ww_ctx(void *arg)
> return PTR_ERR(obj);
>
> obj2 = i915_gem_object_create_internal(i915, PAGE_SIZE);
> - if (IS_ERR(obj)) {
> - err = PTR_ERR(obj);
> + if (IS_ERR(obj2)) {
> + err = PTR_ERR(obj2);
> goto put1;
> }
ops...
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()
2020-09-11 11:34 [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() Dan Carpenter
2020-09-11 12:11 ` [Intel-gfx] " Andi Shyti
@ 2020-09-11 13:02 ` Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Tvrtko Ursulin @ 2020-09-11 13:02 UTC (permalink / raw)
To: Dan Carpenter, Jani Nikula
Cc: David Airlie, intel-gfx, kernel-janitors, Chris Wilson,
Thomas Hellström, Matthew Auld
On 11/09/2020 12:34, Dan Carpenter wrote:
> There is a copy and paste error here. The "obj" should be "obj2". The
> current code could result in an Oops.
>
> Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
> index 23a6132c5f4e..412e21604a05 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
> @@ -211,8 +211,8 @@ static int igt_gem_ww_ctx(void *arg)
> return PTR_ERR(obj);
>
> obj2 = i915_gem_object_create_internal(i915, PAGE_SIZE);
> - if (IS_ERR(obj)) {
> - err = PTR_ERR(obj);
> + if (IS_ERR(obj2)) {
> + err = PTR_ERR(obj2);
> goto put1;
> }
>
>
Oopsie I did point this out in review! (msgid
c03481f1-92c2-24ad-b56e-a92fbb70f9fe@linux.intel.com)
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-11 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 11:34 [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() Dan Carpenter
2020-09-11 12:11 ` [Intel-gfx] " Andi Shyti
2020-09-11 13:02 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).