* [PATCH] mfd: sm501: Fix leaks in probe()
@ 2020-09-11 11:33 Dan Carpenter
2020-09-24 12:40 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-09-11 11:33 UTC (permalink / raw)
To: Lee Jones
Cc: Ben Dooks, Andrew Morton, Vincent Sanders, linux-kernel, kernel-janitors
This code should clean up if sm501_init_dev() fails.
Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/mfd/sm501.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index ccd62b963952..6d2f4a0a901d 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1415,8 +1415,14 @@ static int sm501_plat_probe(struct platform_device *dev)
goto err_claim;
}
- return sm501_init_dev(sm);
+ ret = sm501_init_dev(sm);
+ if (ret)
+ goto err_unmap;
+
+ return 0;
+ err_unmap:
+ iounmap(sm->regs);
err_claim:
release_mem_region(sm->io_res->start, 0x100);
err_res:
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: sm501: Fix leaks in probe()
2020-09-11 11:33 [PATCH] mfd: sm501: Fix leaks in probe() Dan Carpenter
@ 2020-09-24 12:40 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-09-24 12:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ben Dooks, Andrew Morton, Vincent Sanders, linux-kernel, kernel-janitors
On Fri, 11 Sep 2020, Dan Carpenter wrote:
> This code should clean up if sm501_init_dev() fails.
>
> Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/mfd/sm501.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-24 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 11:33 [PATCH] mfd: sm501: Fix leaks in probe() Dan Carpenter
2020-09-24 12:40 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).