* [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page()
@ 2020-09-24 8:18 Dan Carpenter
2020-09-24 8:26 ` Christoph Hellwig
2020-09-24 23:15 ` Stephen Rothwell
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-09-24 8:18 UTC (permalink / raw)
To: Andrew Morton, Christoph Hellwig, Jani Nikula
Cc: Abdiel Janulgue, Stephen Rothwell, David Airlie, intel-gfx,
kernel-janitors, linux-kernel, Chris Wilson, Matthew Auld,
Dave Airlie
The "i" iterator is never set to zero. This probably doesn't affect
testing because GCC sometimes initializes variables and also we have a
new pluggin to initialize stack variables to zero.
Fixes: 7edd32a9e614 ("drm/i915: use vmap in i915_gem_object_map")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Hi Andrew, this should probably go through the -mm tree and get folded
into the original patch.
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 90029ea83aed..12bedabc1daa 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -266,6 +266,7 @@ static void *i915_gem_object_map_page(struct drm_i915_gem_object *obj,
return NULL;
}
+ i = 0;
for_each_sgt_page(page, iter, obj->mm.pages)
pages[i++] = page;
vaddr = vmap(pages, n_pages, 0, pgprot);
@@ -291,6 +292,7 @@ static void *i915_gem_object_map_pfn(struct drm_i915_gem_object *obj)
return NULL;
}
+ i = 0;
for_each_sgt_daddr(addr, iter, obj->mm.pages)
pfns[i++] = (iomap + addr) >> PAGE_SHIFT;
vaddr = vmap_pfn(pfns, n_pfn, pgprot_writecombine(PAGE_KERNEL_IO));
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page()
2020-09-24 8:18 [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page() Dan Carpenter
@ 2020-09-24 8:26 ` Christoph Hellwig
2020-09-24 23:15 ` Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-09-24 8:26 UTC (permalink / raw)
To: Dan Carpenter
Cc: Abdiel Janulgue, Stephen Rothwell, David Airlie, intel-gfx,
kernel-janitors, linux-kernel, Chris Wilson, Matthew Auld,
Dave Airlie, Andrew Morton, Christoph Hellwig
On Thu, Sep 24, 2020 at 11:18:30AM +0300, Dan Carpenter wrote:
> The "i" iterator is never set to zero. This probably doesn't affect
> testing because GCC sometimes initializes variables and also we have a
> new pluggin to initialize stack variables to zero.
>
> Fixes: 7edd32a9e614 ("drm/i915: use vmap in i915_gem_object_map")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Hi Andrew, this should probably go through the -mm tree and get folded
> into the original patch.
FYI, I'll need to resend anyway, and I've folded this into the latest
branch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page()
2020-09-24 8:18 [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page() Dan Carpenter
2020-09-24 8:26 ` Christoph Hellwig
@ 2020-09-24 23:15 ` Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2020-09-24 23:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: Abdiel Janulgue, David Airlie, intel-gfx, kernel-janitors,
linux-kernel, Chris Wilson, Matthew Auld, Dave Airlie,
Andrew Morton, Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
Hi Dan,
On Thu, 24 Sep 2020 11:18:30 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The "i" iterator is never set to zero. This probably doesn't affect
> testing because GCC sometimes initializes variables and also we have a
> new pluggin to initialize stack variables to zero.
>
> Fixes: 7edd32a9e614 ("drm/i915: use vmap in i915_gem_object_map")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Hi Andrew, this should probably go through the -mm tree and get folded
> into the original patch.
Added to linux-next today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-24 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-24 8:18 [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page() Dan Carpenter
2020-09-24 8:26 ` Christoph Hellwig
2020-09-24 23:15 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).