* [PATCH][next] SFH: remove redundant initialization of pointer cl_data
@ 2020-11-02 11:12 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2020-11-02 11:12 UTC (permalink / raw)
To: Nehal Shah, Sandeep Singh, Jiri Kosina, Benjamin Tissoires, linux-input
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer cl_data is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_client.c b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
index 3d1ccac5d99a..7eaf519737c0 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_client.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
@@ -133,7 +133,7 @@ static void amd_sfh_work_buffer(struct work_struct *work)
int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
{
- struct amdtp_cl_data *cl_data = privdata->cl_data;
+ struct amdtp_cl_data *cl_data;
struct amd_mp2_sensor_info info;
struct device *dev;
u32 feature_report_size;
--
2.27.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-02 11:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 11:12 [PATCH][next] SFH: remove redundant initialization of pointer cl_data Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).