[PATCH][next] wilc1000: remove redundant assignment to pointer vif

[PATCH][next] wilc1000: remove redundant assignment to pointer vif

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The assignment to pointer vif is redundant as the assigned value
is never read, hence it can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/microchip/wilc1000/wlan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index 993ea7c03429..c12f27be9f79 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -685,7 +685,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
 			if (!tqe_q[ac])
 				continue;
 
-			vif = tqe_q[ac]->vif;
 			ac_exist = 1;
 			for (k = 0; (k < num_pkts_to_add[ac]) &&
 			     (!max_size_over) && tqe_q[ac]; k++) {
-- 
2.29.2

Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif

[Ajay.Kathat]

DQoNCk9uIDAzLzEyLzIwIDExOjEzIHBtLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBFWFRFUk5BTCBF
TUFJTDogRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW5sZXNzIHlvdSBr
bm93IHRoZSBjb250ZW50IGlzIHNhZmUNCj4gDQo+IEZyb206IENvbGluIElhbiBLaW5nIDxjb2xp
bi5raW5nQGNhbm9uaWNhbC5jb20+DQo+IA0KPiBUaGUgYXNzaWdubWVudCB0byBwb2ludGVyIHZp
ZiBpcyByZWR1bmRhbnQgYXMgdGhlIGFzc2lnbmVkIHZhbHVlDQo+IGlzIG5ldmVyIHJlYWQsIGhl
bmNlIGl0IGNhbiBiZSByZW1vdmVkLg0KPiANCj4gQWRkcmVzc2VzLUNvdmVyaXR5OiAoIlVudXNl
ZCB2YWx1ZSIpDQo+IFNpZ25lZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNh
bm9uaWNhbC5jb20+DQoNClRoYW5rcy4NCg0KQWNrZWQtYnk6IEFqYXkgU2luZ2ggPGFqYXkua2F0
aGF0QG1pY3JvY2hpcC5jb20+DQoNCj4gLS0tDQo+ICBkcml2ZXJzL25ldC93aXJlbGVzcy9taWNy
b2NoaXAvd2lsYzEwMDAvd2xhbi5jIHwgMSAtDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBkZWxldGlv
bigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21pY3JvY2hpcC93
aWxjMTAwMC93bGFuLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9taWNyb2NoaXAvd2lsYzEwMDAv
d2xhbi5jDQo+IGluZGV4IDk5M2VhN2MwMzQyOS4uYzEyZjI3YmU5Zjc5IDEwMDY0NA0KPiAtLS0g
YS9kcml2ZXJzL25ldC93aXJlbGVzcy9taWNyb2NoaXAvd2lsYzEwMDAvd2xhbi5jDQo+ICsrKyBi
L2RyaXZlcnMvbmV0L3dpcmVsZXNzL21pY3JvY2hpcC93aWxjMTAwMC93bGFuLmMNCj4gQEAgLTY4
NSw3ICs2ODUsNiBAQCBpbnQgd2lsY193bGFuX2hhbmRsZV90eHEoc3RydWN0IHdpbGMgKndpbGMs
IHUzMiAqdHhxX2NvdW50KQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIXRxZV9xW2Fj
XSkNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gDQo+IC0g
ICAgICAgICAgICAgICAgICAgICAgIHZpZiA9IHRxZV9xW2FjXS0+dmlmOw0KPiAgICAgICAgICAg
ICAgICAgICAgICAgICBhY19leGlzdCA9IDE7DQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGZv
ciAoayA9IDA7IChrIDwgbnVtX3BrdHNfdG9fYWRkW2FjXSkgJiYNCj4gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAoIW1heF9zaXplX292ZXIpICYmIHRxZV9xW2FjXTsgaysrKSB7DQo+IC0t
DQo+IDIuMjkuMg0KPiA

Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif

[Kalle Valo]

Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment to pointer vif is redundant as the assigned value
> is never read, hence it can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>

Patch applied to wireless-drivers-next.git, thanks.

9b0467ed9a7d wilc1000: remove redundant assignment to pointer vif

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20201203174316.1071446-1-colin.king@canonical.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches