From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] octeontx2-af: cn10k: MAC internal loopback support
Date: Tue, 16 Feb 2021 10:14:53 +0000 [thread overview]
Message-ID: <20210216101453.GF2222@kadam> (raw)
In-Reply-To: <YCuaqPZw9V8HeCrU@mwanda>
On Tue, Feb 16, 2021 at 01:12:56PM +0300, Dan Carpenter wrote:
> Hello Hariprasad Kelam,
>
> The patch 3ad3f8f93c81: "octeontx2-af: cn10k: MAC internal loopback
> support" from Feb 11, 2021, leads to the following static checker
> warning:
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731 rvu_cgx_config_intlbk()
> error: uninitialized symbol 'cgx_id'.
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> 723 static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
> 724 {
> 725 struct mac_ops *mac_ops;
> 726 u8 cgx_id, lmac_id;
> ^^^^^^
>
> 727
> 728 if (!is_cgx_config_permitted(rvu, pcifunc))
> 729 return -EPERM;
> 730
> 731 mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
> ^^^^^^
> Uninitialized. This code probably hasn't been tested very well.
>
> 732
> 733 return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
> 734 lmac_id, en);
^^^^^^^
drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:734
rvu_cgx_config_intlbk() error: uninitialized symbol 'lmac_id'.
This isn't initialized either.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: hkelam@marvell.com
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] octeontx2-af: cn10k: MAC internal loopback support
Date: Tue, 16 Feb 2021 13:14:53 +0300 [thread overview]
Message-ID: <20210216101453.GF2222@kadam> (raw)
Message-ID: <20210216101453.UZGNoxySpI3S2q2kbN52tx-ACMQiyIRAcnaJxglRTUw@z> (raw)
In-Reply-To: <YCuaqPZw9V8HeCrU@mwanda>
On Tue, Feb 16, 2021 at 01:12:56PM +0300, Dan Carpenter wrote:
> Hello Hariprasad Kelam,
>
> The patch 3ad3f8f93c81: "octeontx2-af: cn10k: MAC internal loopback
> support" from Feb 11, 2021, leads to the following static checker
> warning:
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731 rvu_cgx_config_intlbk()
> error: uninitialized symbol 'cgx_id'.
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> 723 static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
> 724 {
> 725 struct mac_ops *mac_ops;
> 726 u8 cgx_id, lmac_id;
> ^^^^^^
>
> 727
> 728 if (!is_cgx_config_permitted(rvu, pcifunc))
> 729 return -EPERM;
> 730
> 731 mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
> ^^^^^^
> Uninitialized. This code probably hasn't been tested very well.
>
> 732
> 733 return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
> 734 lmac_id, en);
^^^^^^^
drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:734
rvu_cgx_config_intlbk() error: uninitialized symbol 'lmac_id'.
This isn't initialized either.
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-16 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 10:12 [bug report] octeontx2-af: cn10k: MAC internal loopback support Dan Carpenter
2021-02-16 10:12 ` Dan Carpenter
2021-02-16 10:14 ` Dan Carpenter [this message]
2021-02-16 10:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216101453.GF2222@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).