* [PATCH][next] RDMA/hns: Fix uninitialized return value in ret
@ 2021-02-24 16:51 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2021-02-24 16:51 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Weihang Li, Doug Ledford, Jason Gunthorpe, Xi Wang
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently if !r->hopnum is true in the for-loop and later on
mapped_cnt < page_cnt is false we end up with an uninitialized value
in ret being returned at the end of the function hns_roce_mtr_map.
Fix this by keeping the original intent and ensure ret is zero by
initializing ret at the start of the function.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 9ea9a53ea93b ("RDMA/hns: Add mapped page count checking for MTR")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_mr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
index 79b3c3023fe7..b8454dcb0318 100644
--- a/drivers/infiniband/hw/hns/hns_roce_mr.c
+++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
@@ -776,7 +776,7 @@ int hns_roce_mtr_map(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr,
struct ib_device *ibdev = &hr_dev->ib_dev;
struct hns_roce_buf_region *r;
unsigned int i, mapped_cnt;
- int ret;
+ int ret = 0;
/*
* Only use the first page address as root ba when hopnum is 0, this
--
2.30.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-24 16:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 16:51 [PATCH][next] RDMA/hns: Fix uninitialized return value in ret Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).