* [PATCH -next] vp_vdpa: fix error return code in vp_vdpa_probe()
@ 2021-05-19 14:16 Wei Yongjun
2021-05-20 7:05 ` Stefano Garzarella
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-05-19 14:16 UTC (permalink / raw)
To: weiyongjun1, Michael S. Tsirkin, Jason Wang, Eli Cohen,
Stefano Garzarella
Cc: virtualization, linux-kernel, kernel-janitors, Hulk Robot
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
index c76ebb531212..e5d92db728d3 100644
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
vp_modern_map_vq_notify(mdev, i,
&vp_vdpa->vring[i].notify_pa);
if (!vp_vdpa->vring[i].notify) {
+ ret = -ENOMEM;
dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
goto err;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] vp_vdpa: fix error return code in vp_vdpa_probe()
2021-05-19 14:16 [PATCH -next] vp_vdpa: fix error return code in vp_vdpa_probe() Wei Yongjun
@ 2021-05-20 7:05 ` Stefano Garzarella
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Garzarella @ 2021-05-20 7:05 UTC (permalink / raw)
To: Wei Yongjun
Cc: Michael S. Tsirkin, Jason Wang, Eli Cohen, virtualization,
linux-kernel, kernel-janitors, Hulk Robot
On Wed, May 19, 2021 at 02:16:46PM +0000, Wei Yongjun wrote:
>Fix to return negative error code -ENOMEM from the error handling
>case instead of 0, as done elsewhere in this function.
>
>Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
>Reported-by: Hulk Robot <hulkci@huawei.com>
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
>index c76ebb531212..e5d92db728d3 100644
>--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
>+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
>@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> vp_modern_map_vq_notify(mdev, i,
> &vp_vdpa->vring[i].notify_pa);
> if (!vp_vdpa->vring[i].notify) {
>+ ret = -ENOMEM;
> dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
> goto err;
> }
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-20 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 14:16 [PATCH -next] vp_vdpa: fix error return code in vp_vdpa_probe() Wei Yongjun
2021-05-20 7:05 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).