* [PATCH][next] net: usb: asix: ax88772: Fix less than zero comparison of a u16
@ 2021-06-08 14:58 Colin King
2021-06-08 15:05 ` NAK: " Colin Ian King
2021-06-09 9:51 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-06-08 14:58 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Oleksij Rempel, linux-usb, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The comparison of the u16 priv->phy_addr < 0 is always false because
phy_addr is unsigned. Fix this by assigning the return from the call
to function asix_read_phy_addr to int ret and using this for the
less than zero error check comparison.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/usb/asix_devices.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 57dafb3262d9..211c5a87eb15 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -704,9 +704,10 @@ static int ax88772_init_phy(struct usbnet *dev)
struct asix_common_private *priv = dev->driver_priv;
int ret;
- priv->phy_addr = asix_read_phy_addr(dev, true);
- if (priv->phy_addr < 0)
+ ret = asix_read_phy_addr(dev, true);
+ if (ret < 0)
return priv->phy_addr;
+ priv->phy_addr = ret;
snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT,
priv->mdio->id, priv->phy_addr);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* NAK: [PATCH][next] net: usb: asix: ax88772: Fix less than zero comparison of a u16
2021-06-08 14:58 [PATCH][next] net: usb: asix: ax88772: Fix less than zero comparison of a u16 Colin King
@ 2021-06-08 15:05 ` Colin Ian King
2021-06-09 9:51 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2021-06-08 15:05 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Oleksij Rempel, linux-usb, netdev
Cc: kernel-janitors, linux-kernel
On 08/06/2021 15:58, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparison of the u16 priv->phy_addr < 0 is always false because
> phy_addr is unsigned. Fix this by assigning the return from the call
> to function asix_read_phy_addr to int ret and using this for the
> less than zero error check comparison.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/usb/asix_devices.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 57dafb3262d9..211c5a87eb15 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -704,9 +704,10 @@ static int ax88772_init_phy(struct usbnet *dev)
> struct asix_common_private *priv = dev->driver_priv;
> int ret;
>
> - priv->phy_addr = asix_read_phy_addr(dev, true);
> - if (priv->phy_addr < 0)
> + ret = asix_read_phy_addr(dev, true);
> + if (ret < 0)
> return priv->phy_addr;
> + priv->phy_addr = ret;
>
> snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT,
> priv->mdio->id, priv->phy_addr);
>
Wrong commit message. I'll send a new fix.
Colin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: usb: asix: ax88772: Fix less than zero comparison of a u16
2021-06-08 14:58 [PATCH][next] net: usb: asix: ax88772: Fix less than zero comparison of a u16 Colin King
2021-06-08 15:05 ` NAK: " Colin Ian King
@ 2021-06-09 9:51 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2021-06-09 9:51 UTC (permalink / raw)
To: Colin King, David S . Miller, Jakub Kicinski, Oleksij Rempel,
linux-usb, netdev
Cc: kernel-janitors, linux-kernel
On 08.06.2021 17:58, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparison of the u16 priv->phy_addr < 0 is always false because
> phy_addr is unsigned. Fix this by assigning the return from the call
> to function asix_read_phy_addr to int ret and using this for the
> less than zero error check comparison.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/usb/asix_devices.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 57dafb3262d9..211c5a87eb15 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -704,9 +704,10 @@ static int ax88772_init_phy(struct usbnet *dev)
> struct asix_common_private *priv = dev->driver_priv;
> int ret;
>
> - priv->phy_addr = asix_read_phy_addr(dev, true);
> - if (priv->phy_addr < 0)
> + ret = asix_read_phy_addr(dev, true);
> + if (ret < 0)
> return priv->phy_addr;
It's not yet assigned at this point, should be:
return ret;
> + priv->phy_addr = ret;
Assigned only here. :-)
> snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT,
> priv->mdio->id, priv->phy_addr);
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 14:58 [PATCH][next] net: usb: asix: ax88772: Fix less than zero comparison of a u16 Colin King
2021-06-08 15:05 ` NAK: " Colin Ian King
2021-06-09 9:51 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).