* [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail
@ 2021-06-09 7:27 Baokun Li
2021-06-10 14:17 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Baokun Li @ 2021-06-09 7:27 UTC (permalink / raw)
To: linux-kernel, Peter Chen, Pawel Laszczak, Greg Kroah-Hartman
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1,
linux-usb, kernel-janitors, Hulk Robot
Using list_move_tail() instead of list_del() + list_add_tail().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
CC mailist
drivers/usb/cdns3/cdns3-gadget.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
index 57adcdbfab5f..5d8c982019af 100644
--- a/drivers/usb/cdns3/cdns3-gadget.c
+++ b/drivers/usb/cdns3/cdns3-gadget.c
@@ -430,9 +430,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
if (ret)
return ret;
- list_del(&request->list);
- list_add_tail(&request->list,
- &priv_ep->pending_req_list);
+ list_move_tail(&request->list, &priv_ep->pending_req_list);
if (request->stream_id != 0 || (priv_ep->flags & EP_TDLCHK_EN))
break;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail
2021-06-09 7:27 [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail Baokun Li
@ 2021-06-10 14:17 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2021-06-10 14:17 UTC (permalink / raw)
To: Baokun Li
Cc: linux-kernel, Pawel Laszczak, Greg Kroah-Hartman, weiyongjun1,
yuehaibing, yangjihong1, yukuai3, linux-usb, kernel-janitors,
Hulk Robot
On 21-06-09 15:27:20, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> V1->V2:
> CC mailist
>
> drivers/usb/cdns3/cdns3-gadget.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 57adcdbfab5f..5d8c982019af 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -430,9 +430,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
> if (ret)
> return ret;
>
> - list_del(&request->list);
> - list_add_tail(&request->list,
> - &priv_ep->pending_req_list);
> + list_move_tail(&request->list, &priv_ep->pending_req_list);
> if (request->stream_id != 0 || (priv_ep->flags & EP_TDLCHK_EN))
> break;
> }
>
Applied, thanks.
--
Thanks,
Peter Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 7:27 [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add_tail Baokun Li
2021-06-10 14:17 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).