* [PATCH net-next] net: ena: make symbol 'ena_alloc_map_page' static
@ 2021-06-09 14:25 Wei Yongjun
2021-06-09 22:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-06-09 14:25 UTC (permalink / raw)
To: weiyongjun1, Netanel Belgazal, Arthur Kiyanovski,
David S. Miller, Jakub Kicinski, Alexei Starovoitov,
Daniel Borkmann, Jesper Dangaard Brouer, John Fastabend,
Andrii Nakryiko, Shay Agroskin, Sameeh Jubran, Lorenzo Bianconi
Cc: netdev, bpf, kernel-janitors, Hulk Robot
The sparse tool complains as follows:
drivers/net/ethernet/amazon/ena/ena_netdev.c:978:13: warning:
symbol 'ena_alloc_map_page' was not declared. Should it be static?
This symbol is not used outside of ena_netdev.c, so marks it static.
Fixes: 947c54c395cb ("net: ena: Use dev_alloc() in RX buffer allocation")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index cd6ea59c543c..3bb0e66b2c7e 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -975,7 +975,8 @@ static void ena_free_all_io_rx_resources(struct ena_adapter *adapter)
ena_free_rx_resources(adapter, i);
}
-struct page *ena_alloc_map_page(struct ena_ring *rx_ring, dma_addr_t *dma)
+static struct page *ena_alloc_map_page(struct ena_ring *rx_ring,
+ dma_addr_t *dma)
{
struct page *page;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ena: make symbol 'ena_alloc_map_page' static
2021-06-09 14:25 [PATCH net-next] net: ena: make symbol 'ena_alloc_map_page' static Wei Yongjun
@ 2021-06-09 22:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-09 22:40 UTC (permalink / raw)
To: Wei Yongjun
Cc: netanel, akiyano, davem, kuba, ast, daniel, hawk, john.fastabend,
andrii, shayagr, sameehj, lorenzo, netdev, bpf, kernel-janitors,
hulkci
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 9 Jun 2021 14:25:06 +0000 you wrote:
> The sparse tool complains as follows:
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c:978:13: warning:
> symbol 'ena_alloc_map_page' was not declared. Should it be static?
>
> This symbol is not used outside of ena_netdev.c, so marks it static.
>
> [...]
Here is the summary with links:
- [net-next] net: ena: make symbol 'ena_alloc_map_page' static
https://git.kernel.org/netdev/net-next/c/6fb566c9278a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 14:25 [PATCH net-next] net: ena: make symbol 'ena_alloc_map_page' static Wei Yongjun
2021-06-09 22:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).