* [PATCH] iio: light: si1145: remove redundant continue statement
@ 2021-06-17 8:13 Colin King
2021-07-18 14:44 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-06-17 8:13 UTC (permalink / raw)
To: Lars-Peter Clausen, linux-iio; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The continue statement at the end of a for-loop has no effect,
remove it.
Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/iio/light/si1145.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c
index e2abad48b9f4..e8f6cdf26f22 100644
--- a/drivers/iio/light/si1145.c
+++ b/drivers/iio/light/si1145.c
@@ -220,7 +220,6 @@ static int __si1145_command_reset(struct si1145_data *data)
return -ETIMEDOUT;
}
msleep(SI1145_COMMAND_MINSLEEP_MS);
- continue;
}
}
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: light: si1145: remove redundant continue statement
2021-06-17 8:13 [PATCH] iio: light: si1145: remove redundant continue statement Colin King
@ 2021-07-18 14:44 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-07-18 14:44 UTC (permalink / raw)
To: Colin King; +Cc: Lars-Peter Clausen, linux-iio, kernel-janitors, linux-kernel
On Thu, 17 Jun 2021 09:13:12 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The continue statement at the end of a for-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/light/si1145.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c
> index e2abad48b9f4..e8f6cdf26f22 100644
> --- a/drivers/iio/light/si1145.c
> +++ b/drivers/iio/light/si1145.c
> @@ -220,7 +220,6 @@ static int __si1145_command_reset(struct si1145_data *data)
> return -ETIMEDOUT;
> }
> msleep(SI1145_COMMAND_MINSLEEP_MS);
> - continue;
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-18 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 8:13 [PATCH] iio: light: si1145: remove redundant continue statement Colin King
2021-07-18 14:44 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).