* [PATCH] ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write()
@ 2021-07-30 15:08 Dan Carpenter
2021-07-30 23:22 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-07-30 15:08 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, kernel-janitors
I accidentally introduced a bug in my previous patch. The "ret"
variable needs to be initialized to prevent returning uninitialized
data.
Fixes: f9714eb04364 ("ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Sorry!
drivers/char/ipmi/ssif_bmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index ce8cd8364a3f..acdb1d9cb5c0 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -80,7 +80,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
struct ssif_msg msg;
unsigned long flags;
- ssize_t ret;
+ ssize_t ret = 0;
if (count > sizeof(struct ssif_msg))
return -EINVAL;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write()
2021-07-30 15:08 [PATCH] ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write() Dan Carpenter
@ 2021-07-30 23:22 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2021-07-30 23:22 UTC (permalink / raw)
To: Dan Carpenter; +Cc: openipmi-developer, kernel-janitors
On Fri, Jul 30, 2021 at 06:08:01PM +0300, Dan Carpenter wrote:
> I accidentally introduced a bug in my previous patch. The "ret"
> variable needs to be initialized to prevent returning uninitialized
> data.
Thanks Dan, it's queued.
-corey
>
> Fixes: f9714eb04364 ("ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Sorry!
>
> drivers/char/ipmi/ssif_bmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index ce8cd8364a3f..acdb1d9cb5c0 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -80,7 +80,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
> struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
> struct ssif_msg msg;
> unsigned long flags;
> - ssize_t ret;
> + ssize_t ret = 0;
>
> if (count > sizeof(struct ssif_msg))
> return -EINVAL;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-30 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 15:08 [PATCH] ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write() Dan Carpenter
2021-07-30 23:22 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).