* [PATCH] rsi: fix an error code in rsi_probe()
@ 2021-08-16 18:39 Dan Carpenter
2021-08-21 17:27 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-08-16 18:39 UTC (permalink / raw)
To: Amitkumar Karwar, Siva Rebbagondla
Cc: Kalle Valo, linux-wireless, kernel-janitors
Return -ENODEV instead of success for unsupported devices.
Fixes: 54fdb318c111 ("rsi: add new device model for 9116")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/rsi/rsi_91x_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index 3fbe2a3c1455..416976f09888 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -816,6 +816,7 @@ static int rsi_probe(struct usb_interface *pfunction,
} else {
rsi_dbg(ERR_ZONE, "%s: Unsupported RSI device id 0x%x\n",
__func__, id->idProduct);
+ status = -ENODEV;
goto err1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rsi: fix an error code in rsi_probe()
2021-08-16 18:39 [PATCH] rsi: fix an error code in rsi_probe() Dan Carpenter
@ 2021-08-21 17:27 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-08-21 17:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Amitkumar Karwar, Siva Rebbagondla, linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Return -ENODEV instead of success for unsupported devices.
>
> Fixes: 54fdb318c111 ("rsi: add new device model for 9116")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
9adcdf6758d7 rsi: fix an error code in rsi_probe()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210816183947.GA2119@kili/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-21 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 18:39 [PATCH] rsi: fix an error code in rsi_probe() Dan Carpenter
2021-08-21 17:27 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).