[PATCH net-next] mlxsw: spectrum_buffers: silence uninitialized warning

[PATCH net-next] mlxsw: spectrum_buffers: silence uninitialized warning

[Dan Carpenter]

Static checkers and runtime checkers such as KMSan will complain that
we do not initialize the last 6 bytes of "cb_priv".  The caller only
uses the first two bytes so it doesn't cause a runtime issue.  Still
worth fixing though.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c
index 9de160e740b2..d78cf5a7220a 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c
@@ -1583,7 +1583,7 @@ int mlxsw_sp_sb_occ_snapshot(struct mlxsw_core *mlxsw_core,
 {
 	struct mlxsw_sp *mlxsw_sp = mlxsw_core_driver_priv(mlxsw_core);
 	struct mlxsw_sp_sb_sr_occ_query_cb_ctx cb_ctx;
-	unsigned long cb_priv;
+	unsigned long cb_priv = 0;
 	LIST_HEAD(bulk_list);
 	char *sbsr_pl;
 	u8 masked_count;
-- 
2.20.1

Re: [PATCH net-next] mlxsw: spectrum_buffers: silence uninitialized warning

[Ido Schimmel]

On Wed, Oct 06, 2021 at 10:33:47AM +0300, Dan Carpenter wrote:
> Static checkers and runtime checkers such as KMSan will complain that
> we do not initialize the last 6 bytes of "cb_priv".  The caller only
> uses the first two bytes so it doesn't cause a runtime issue.  Still
> worth fixing though.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH net-next] mlxsw: spectrum_buffers: silence uninitialized warning

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 6 Oct 2021 10:33:47 +0300 you wrote:
> Static checkers and runtime checkers such as KMSan will complain that
> we do not initialize the last 6 bytes of "cb_priv".  The caller only
> uses the first two bytes so it doesn't cause a runtime issue.  Still
> worth fixing though.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> [...]

Here is the summary with links:
  - [net-next] mlxsw: spectrum_buffers: silence uninitialized warning
    https://git.kernel.org/netdev/net-next/c/9b139a38016f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html