* [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
@ 2022-09-09 2:46 Sun Ke
2022-09-19 21:09 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Sun Ke @ 2022-09-09 2:46 UTC (permalink / raw)
To: joyce.ooi, davem, edumazet, kuba, pabeni, linux
Cc: netdev, kernel-janitors, sunke32
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sun Ke <sunke32@huawei.com>
---
drivers/net/ethernet/altera/altera_tse_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 89ae6d1623aa..3cf409bdb283 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
priv->phy_iface, &alt_tse_phylink_ops);
if (IS_ERR(priv->phylink)) {
dev_err(&pdev->dev, "failed to create phylink\n");
+ ret = PTR_ERR(priv->phylink);
goto err_init_phy;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
2022-09-09 2:46 [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe() Sun Ke
@ 2022-09-19 21:09 ` Jakub Kicinski
2022-09-20 1:40 ` Sun Ke
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2022-09-19 21:09 UTC (permalink / raw)
To: Sun Ke; +Cc: joyce.ooi, davem, edumazet, pabeni, linux, netdev, kernel-janitors
On Fri, 9 Sep 2022 10:46:17 +0800 Sun Ke wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sun Ke <sunke32@huawei.com>
You must CC Maxime, who authored the change under Fixes,
and is most likely the best person to give us a review.
Please repost with the CC fixed.
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 89ae6d1623aa..3cf409bdb283 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
> priv->phy_iface, &alt_tse_phylink_ops);
> if (IS_ERR(priv->phylink)) {
> dev_err(&pdev->dev, "failed to create phylink\n");
> + ret = PTR_ERR(priv->phylink);
> goto err_init_phy;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
2022-09-19 21:09 ` Jakub Kicinski
@ 2022-09-20 1:40 ` Sun Ke
0 siblings, 0 replies; 3+ messages in thread
From: Sun Ke @ 2022-09-20 1:40 UTC (permalink / raw)
To: Jakub Kicinski
Cc: joyce.ooi, davem, edumazet, pabeni, linux, netdev, kernel-janitors
在 2022/9/20 5:09, Jakub Kicinski 写道:
> On Fri, 9 Sep 2022 10:46:17 +0800 Sun Ke wrote:
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Sun Ke <sunke32@huawei.com>
>
> You must CC Maxime, who authored the change under Fixes,
> and is most likely the best person to give us a review.
> Please repost with the CC fixed.
OK.
Thanks,
Sun Ke
>
>> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
>> index 89ae6d1623aa..3cf409bdb283 100644
>> --- a/drivers/net/ethernet/altera/altera_tse_main.c
>> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
>> @@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
>> priv->phy_iface, &alt_tse_phylink_ops);
>> if (IS_ERR(priv->phylink)) {
>> dev_err(&pdev->dev, "failed to create phylink\n");
>> + ret = PTR_ERR(priv->phylink);
>> goto err_init_phy;
>> }
>>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-20 1:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 2:46 [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe() Sun Ke
2022-09-19 21:09 ` Jakub Kicinski
2022-09-20 1:40 ` Sun Ke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).