kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring
@ 2022-09-19  8:44 Lukas Bulwahn
  0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2022-09-19  8:44 UTC (permalink / raw)
  To: Christoph Hellwig, iommu
  Cc: Juergen Gross, Stefano Stabellini, kernel-janitors, linux-kernel,
	Lukas Bulwahn

Commit 78013eaadf69 ("x86: remove the IOMMU table infrastructure")
refactored the generic swiotlb/swiotlb-xen setup into pci-dma.c, but
misses to adjust MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about
broken references.

Update the SWIOTLB SUBSYSTEM to contain the architecture-independent
pieces for swiotlb, but leave the small architecture-dependent pieces to
the architecture maintainers.

Further, update the XEN SWIOTLB SUBSYSTEM to include all swiotlb-xen
headers and replace the pattern in drivers with the specific one file that
matches this pattern.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Juergen Gross <jgross@suse.com>
---
v1: https://lore.kernel.org/lkml/20220601075613.28245-1-lukas.bulwahn@gmail.com/
v1 -> v2:
  addressed Christoph's comment, removed arch/*/kernel/pci-swiotlb.c
  added Juergen's ack

Christoph, please pick this minor non-urgent clean-up patch for swiotlb.

 MAINTAINERS | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index babb441f7474..69d58c43bd6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19699,7 +19699,6 @@ L:	iommu@lists.linux.dev
 S:	Supported
 W:	http://git.infradead.org/users/hch/dma-mapping.git
 T:	git git://git.infradead.org/users/hch/dma-mapping.git
-F:	arch/*/kernel/pci-swiotlb.c
 F:	include/linux/swiotlb.h
 F:	kernel/dma/swiotlb.c
 
@@ -22403,8 +22402,10 @@ M:	Stefano Stabellini <sstabellini@kernel.org>
 L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
 L:	iommu@lists.linux.dev
 S:	Supported
-F:	arch/x86/xen/*swiotlb*
-F:	drivers/xen/*swiotlb*
+F:	arch/*/include/asm/xen/swiotlb-xen.h
+F:	drivers/xen/swiotlb-xen.c
+F:	include/xen/arm/swiotlb-xen.h
+F:	include/xen/swiotlb-xen.h
 
 XFS FILESYSTEM
 C:	irc://irc.oftc.net/xfs
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring
  2022-09-20  6:43 ` Christoph Hellwig
@ 2022-09-22 10:02   ` Lukas Bulwahn
  0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2022-09-22 10:02 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: iommu, Juergen Gross, Stefano Stabellini, kernel-janitors, linux-kernel

On Tue, Sep 20, 2022 at 8:43 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Sorry for coming up with this only now, but what about just dropping
> the separate swiotlb entry entirely, and just add include/linux/swiotlb.h
> to the dma-mapping entry?

Sure, great idea. I just sent a patch v3 doing so:

https://lore.kernel.org/lkml/20220922100001.12964-1-lukas.bulwahn@gmail.com/

Lukas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring
  2022-09-19  8:47 Lukas Bulwahn
@ 2022-09-20  6:43 ` Christoph Hellwig
  2022-09-22 10:02   ` Lukas Bulwahn
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2022-09-20  6:43 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Christoph Hellwig, iommu, Juergen Gross, Stefano Stabellini,
	kernel-janitors, linux-kernel

Sorry for coming up with this only now, but what about just dropping
the separate swiotlb entry entirely, and just add include/linux/swiotlb.h
to the dma-mapping entry?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring
@ 2022-09-19  8:47 Lukas Bulwahn
  2022-09-20  6:43 ` Christoph Hellwig
  0 siblings, 1 reply; 4+ messages in thread
From: Lukas Bulwahn @ 2022-09-19  8:47 UTC (permalink / raw)
  To: Christoph Hellwig, iommu
  Cc: Juergen Gross, Stefano Stabellini, kernel-janitors, linux-kernel,
	Lukas Bulwahn

Commit 78013eaadf69 ("x86: remove the IOMMU table infrastructure")
refactored the generic swiotlb/swiotlb-xen setup into pci-dma.c, but
misses to adjust MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about
broken references.

Update the SWIOTLB SUBSYSTEM to contain the architecture-independent
pieces for swiotlb, but leave the small architecture-dependent pieces to
the architecture maintainers.

Further, update the XEN SWIOTLB SUBSYSTEM to include all swiotlb-xen
headers and replace the pattern in drivers with the specific one file that
matches this pattern.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Juergen Gross <jgross@suse.com>
---
v1: https://lore.kernel.org/lkml/20220601075613.28245-1-lukas.bulwahn@gmail.com/
v1 -> v2:
  addressed Christoph's comment, removed arch/*/kernel/pci-swiotlb.c
  added Juergen's ack

Christoph, please pick this minor non-urgent clean-up patch for swiotlb.

 MAINTAINERS | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index babb441f7474..69d58c43bd6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19699,7 +19699,6 @@ L:	iommu@lists.linux.dev
 S:	Supported
 W:	http://git.infradead.org/users/hch/dma-mapping.git
 T:	git git://git.infradead.org/users/hch/dma-mapping.git
-F:	arch/*/kernel/pci-swiotlb.c
 F:	include/linux/swiotlb.h
 F:	kernel/dma/swiotlb.c
 
@@ -22403,8 +22402,10 @@ M:	Stefano Stabellini <sstabellini@kernel.org>
 L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
 L:	iommu@lists.linux.dev
 S:	Supported
-F:	arch/x86/xen/*swiotlb*
-F:	drivers/xen/*swiotlb*
+F:	arch/*/include/asm/xen/swiotlb-xen.h
+F:	drivers/xen/swiotlb-xen.c
+F:	include/xen/arm/swiotlb-xen.h
+F:	include/xen/swiotlb-xen.h
 
 XFS FILESYSTEM
 C:	irc://irc.oftc.net/xfs
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-22 10:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19  8:44 [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring Lukas Bulwahn
2022-09-19  8:47 Lukas Bulwahn
2022-09-20  6:43 ` Christoph Hellwig
2022-09-22 10:02   ` Lukas Bulwahn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).