* [PATCH] fs: hfsplus: fix an error code problem in hfsplus_sync_fs()
@ 2024-04-17 8:31 Su Hui
0 siblings, 0 replies; only message in thread
From: Su Hui @ 2024-04-17 8:31 UTC (permalink / raw)
To: nathan, ndesaulniers, morbo, justinstitt
Cc: Su Hui, viro, brauner, hch, linux-fsdevel, linux-kernel, llvm,
kernel-janitors
Clang Static Checker (scan-build) Warning:
fs/hfsplus/super.c: line 236, column 3
Value stored to 'error2' is never read.
Fix this typo error by assigning 'error2' to 'error'.
Fixes: 52399b171dfa ("hfsplus: use raw bio access for the volume headers")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
fs/hfsplus/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
index 97920202790f..5ee9cbccdff9 100644
--- a/fs/hfsplus/super.c
+++ b/fs/hfsplus/super.c
@@ -233,7 +233,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait)
sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE |
REQ_SYNC);
if (!error)
- error2 = error;
+ error = error2;
out:
mutex_unlock(&sbi->alloc_mutex);
mutex_unlock(&sbi->vh_mutex);
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-17 8:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 8:31 [PATCH] fs: hfsplus: fix an error code problem in hfsplus_sync_fs() Su Hui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).