* [PATCH] drm/nouveau/disp: fix an error problem in nvkm_uconn_new()
@ 2024-04-17 8:39 Su Hui
0 siblings, 0 replies; only message in thread
From: Su Hui @ 2024-04-17 8:39 UTC (permalink / raw)
To: kherbst, lyude, dakr, airlied, daniel, nathan, ndesaulniers,
morbo, justinstitt
Cc: Su Hui, bskeggs, airlied, dri-devel, nouveau, linux-kernel, llvm,
kernel-janitors
Clang Static Checker(scan-build) Warning:
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c:line 215, column 4
Value stored to 'ret' is never read.
Return the error code rather than zero when 'conn->info.type' has an
unknown type.
Fixes: 8b7d92cad953 ("drm/nouveau/kms/nv50-: create connectors based on nvkm info")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
index 2dab6612c4fc..6a67d307bf79 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c
@@ -213,13 +213,14 @@ nvkm_uconn_new(const struct nvkm_oclass *oclass, void *argv, u32 argc, struct nv
default:
WARN_ON(1);
ret = -EINVAL;
- break;
+ goto err;
}
nvkm_object_ctor(&nvkm_uconn, oclass, &conn->object);
*pobject = &conn->object;
ret = 0;
}
+err:
spin_unlock(&disp->client.lock);
return ret;
}
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-17 8:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 8:39 [PATCH] drm/nouveau/disp: fix an error problem in nvkm_uconn_new() Su Hui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).