* Re: [PATCH 1/4] usb: typec: ucsi: Fix null deref in trace
[not found] <20240419211650.2657096-2-jthies@google.com>
@ 2024-04-20 13:15 ` Markus Elfring
2024-04-20 13:20 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2024-04-20 13:15 UTC (permalink / raw)
To: Abhishek Pandit-Subedi, linux-usb, kernel-janitors,
Heikki Krogerus, Jameson Thies
Cc: LKML, Benson Leung, Bjorn Andersson, Dmitry Baryshkov,
Fabrice Gasnier, Greg Kroah-Hartman, Hans de Goede,
Neil Armstrong, Rajaram Regupathy, Saranya Gopal
> ucsi_register_altmode checks IS_ERR on returned pointer and treats
> NULL as valid. This results in a null deref when
> trace_ucsi_register_altmode is called.
I find that the change description can be improved further.
Is another imperative wording desirable?
Can it be nicer to use the term “dereference” for the final commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4] usb: typec: ucsi: Fix null deref in trace
2024-04-20 13:15 ` [PATCH 1/4] usb: typec: ucsi: Fix null deref in trace Markus Elfring
@ 2024-04-20 13:20 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-04-20 13:20 UTC (permalink / raw)
To: Markus Elfring
Cc: Abhishek Pandit-Subedi, linux-usb, kernel-janitors,
Heikki Krogerus, Jameson Thies, LKML, Benson Leung,
Bjorn Andersson, Dmitry Baryshkov, Fabrice Gasnier,
Hans de Goede, Neil Armstrong, Rajaram Regupathy, Saranya Gopal
On Sat, Apr 20, 2024 at 03:15:16PM +0200, Markus Elfring wrote:
> > ucsi_register_altmode checks IS_ERR on returned pointer and treats
> > NULL as valid. This results in a null deref when
> > trace_ucsi_register_altmode is called.
>
> I find that the change description can be improved further.
> Is another imperative wording desirable?
>
> Can it be nicer to use the term “dereference” for the final commit message?
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-20 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240419211650.2657096-2-jthies@google.com>
2024-04-20 13:15 ` [PATCH 1/4] usb: typec: ucsi: Fix null deref in trace Markus Elfring
2024-04-20 13:20 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).