From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>, "Kangjie Lu" <kjlu@umn.edu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Shirish S" <shirish.s@amd.com>,
"Navid Emamdoost" <emamd001@umn.edu>,
"Qiushi Wu" <wu000273@umn.edu>,
"Stephen McCamant" <smccaman@umn.edu>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Yu Kuai" <yukuai3@huawei.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config
Date: Sun, 14 Jun 2020 13:05:46 +0000 [thread overview]
Message-ID: <241aaf11-d4a0-e5a9-9744-75839006c128@web.de> (raw)
> in amdgpu_display_crtc_set_config, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Can it be nicer to combine proposed updates for this software module
as a patch series (with a cover letter)?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
…
> @@ -306,6 +306,7 @@ int amdgpu_display_crtc_set_config(struct drm_mode_set *set,
> adev->have_disp_power_ref = false;
> }
>
> +out:
> /* drop the power reference we got coming in here */
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
Perhaps use the label “put_runtime” instead?
Regards,
Markus
reply other threads:[~2020-06-14 13:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=241aaf11-d4a0-e5a9-9744-75839006c128@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrey.grodzovsky@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=shirish.s@amd.com \
--cc=smccaman@umn.edu \
--cc=tzimmermann@suse.de \
--cc=wu000273@umn.edu \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).