* Re: [PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config
@ 2020-06-14 13:05 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-14 13:05 UTC (permalink / raw)
To: Navid Emamdoost, amd-gfx, dri-devel
Cc: Andrey Grodzovsky, Daniel Vetter, Thomas Zimmermann,
David Airlie, Kangjie Lu, kernel-janitors, linux-kernel,
Shirish S, Navid Emamdoost, Qiushi Wu, Stephen McCamant,
Alex Deucher, Yu Kuai, Christian König
> in amdgpu_display_crtc_set_config, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Can it be nicer to combine proposed updates for this software module
as a patch series (with a cover letter)?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
…
> @@ -306,6 +306,7 @@ int amdgpu_display_crtc_set_config(struct drm_mode_set *set,
> adev->have_disp_power_ref = false;
> }
>
> +out:
> /* drop the power reference we got coming in here */
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
Perhaps use the label “put_runtime” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-14 13:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 13:05 [PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).