kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: ti: delete some dead code in omap_abe_probe()
@ 2021-06-30 11:18 Dan Carpenter
  2021-06-30 14:04 ` Péter Ujfalusi
  2021-07-12 10:45 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-06-30 11:18 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: Jarkko Nikula, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, linux-omap, kernel-janitors

This code checks "priv->mclk_freq" twice and the second check is not
required.  The code is left over from when removed support for legacy
boot.

Fixes: 8fe120b5a665 ("ASoC: omap-abe-twl6040: Remove support for pdata (legacy boot)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 sound/soc/ti/omap-abe-twl6040.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sound/soc/ti/omap-abe-twl6040.c b/sound/soc/ti/omap-abe-twl6040.c
index 91cc9a4f44d7..2e3d1eea77c1 100644
--- a/sound/soc/ti/omap-abe-twl6040.c
+++ b/sound/soc/ti/omap-abe-twl6040.c
@@ -292,11 +292,6 @@ static int omap_abe_probe(struct platform_device *pdev)
 
 	card->fully_routed = 1;
 
-	if (!priv->mclk_freq) {
-		dev_err(&pdev->dev, "MCLK frequency missing\n");
-		return -ENODEV;
-	}
-
 	card->dai_link = priv->dai_links;
 	card->num_links = num_links;
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: ti: delete some dead code in omap_abe_probe()
  2021-06-30 11:18 [PATCH] ASoC: ti: delete some dead code in omap_abe_probe() Dan Carpenter
@ 2021-06-30 14:04 ` Péter Ujfalusi
  2021-07-12 10:45 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2021-06-30 14:04 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Jarkko Nikula, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, linux-omap, kernel-janitors



On 30/06/2021 14:18, Dan Carpenter wrote:
> This code checks "priv->mclk_freq" twice and the second check is not
> required.  The code is left over from when removed support for legacy
> boot.

Good find, thank you!

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> Fixes: 8fe120b5a665 ("ASoC: omap-abe-twl6040: Remove support for pdata (legacy boot)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  sound/soc/ti/omap-abe-twl6040.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/sound/soc/ti/omap-abe-twl6040.c b/sound/soc/ti/omap-abe-twl6040.c
> index 91cc9a4f44d7..2e3d1eea77c1 100644
> --- a/sound/soc/ti/omap-abe-twl6040.c
> +++ b/sound/soc/ti/omap-abe-twl6040.c
> @@ -292,11 +292,6 @@ static int omap_abe_probe(struct platform_device *pdev)
>  
>  	card->fully_routed = 1;
>  
> -	if (!priv->mclk_freq) {
> -		dev_err(&pdev->dev, "MCLK frequency missing\n");
> -		return -ENODEV;
> -	}
> -
>  	card->dai_link = priv->dai_links;
>  	card->num_links = num_links;
>  
> 

-- 
Péter

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: ti: delete some dead code in omap_abe_probe()
  2021-06-30 11:18 [PATCH] ASoC: ti: delete some dead code in omap_abe_probe() Dan Carpenter
  2021-06-30 14:04 ` Péter Ujfalusi
@ 2021-07-12 10:45 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-07-12 10:45 UTC (permalink / raw)
  To: Peter Ujfalusi, Dan Carpenter
  Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, kernel-janitors,
	Liam Girdwood, Jarkko Nikula, alsa-devel, linux-omap

On Wed, 30 Jun 2021 14:18:53 +0300, Dan Carpenter wrote:
> This code checks "priv->mclk_freq" twice and the second check is not
> required.  The code is left over from when removed support for legacy
> boot.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ti: delete some dead code in omap_abe_probe()
      commit: 3666a8f820075e99539ab50687e80fadf997822f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-12 10:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 11:18 [PATCH] ASoC: ti: delete some dead code in omap_abe_probe() Dan Carpenter
2021-06-30 14:04 ` Péter Ujfalusi
2021-07-12 10:45 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).