From: Markus Elfring <Markus.Elfring@web.de>
To: Shengjiu Wang <shengjiu.wang@gmail.com>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org
Cc: Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API
Date: Tue, 23 Jun 2020 08:55:52 +0000 [thread overview]
Message-ID: <24be48d2-63de-b900-cec7-d21e83a89ca2@web.de> (raw)
In-Reply-To: <CAA+D8APR2NGAn9jRDSZzr1fgj5u0hAvH19VxZS+tj2A7j3PCuw@mail.gmail.com>
> clk_prepare_enable and clk_disable_unprepare check the input
> clock parameter in the beginning of the function,
These functions call further functions which perform null pointer checks.
> if the parameter
> is NULL, clk_prepare_enable and clk_disable_unprepare will
> return immediately.
The interpretation of these function implementations seems to be reasonable.
Would you like to achieve any improvements for the corresponding software documentation?
> So Don't need to check input clock parameters before calling clk API.
What do you find imperative in this wording?
Another wording alternative:
Thus omit extra null pointer checks before four function calls.
Regards,
Markus
next prev parent reply other threads:[~2020-06-23 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 7:36 [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API Markus Elfring
2020-06-23 8:32 ` Shengjiu Wang
2020-06-23 8:55 ` Markus Elfring [this message]
2020-06-23 11:35 ` Shengjiu Wang
2020-06-23 12:45 ` [v2 " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24be48d2-63de-b900-cec7-d21e83a89ca2@web.de \
--to=markus.elfring@web.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).