archive mirror
 help / color / mirror / Atom feed
From: Shengjiu Wang <>
To: Markus Elfring <>
Cc: Linux-ALSA <>,
	Timur Tabi <>, Xiubo Li <>,
	Fabio Estevam <>,
	Shengjiu Wang <>,, Takashi Iwai <>,
	linux-kernel <>,
	Nicolin Chen <>,
	Mark Brown <>,
Subject: Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API
Date: Tue, 23 Jun 2020 08:32:02 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Jun 23, 2020 at 3:38 PM Markus Elfring <> wrote:
> > In-Reply-To: <>
> I guess that it should be sufficient to specify such a field once
> for the header information.

seems it's caused by my "git format-patch" command, I will update
it, hope it is better next time.

> > Because clk_prepare_enable and clk_disable_unprepare should
> > check input clock parameter is NULL or not internally,
> I find this change description unclear.

    clk_prepare_enable and clk_disable_unprepare check the input
    clock parameter in the beginning of the function, if the parameter
    is NULL, clk_prepare_enable and clk_disable_unprepare will
    return immediately.

    So Don't need to check input clock parameters before calling clk

Do you think this commit message is better?

best regards
wang shengjiu

  reply	other threads:[~2020-06-23  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  7:36 [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API Markus Elfring
2020-06-23  8:32 ` Shengjiu Wang [this message]
2020-06-23  8:55   ` Markus Elfring
2020-06-23 11:35     ` Shengjiu Wang
2020-06-23 12:45       ` [v2 " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).