kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages
       [not found] ` <20210714194806.55962-17-sashal@kernel.org>
@ 2021-07-16 19:22   ` Marion & Christophe JAILLET
  2021-07-21 10:42     ` Sasha Levin
  0 siblings, 1 reply; 2+ messages in thread
From: Marion & Christophe JAILLET @ 2021-07-16 19:22 UTC (permalink / raw)
  To: Sasha Levin, linux-kernel, stable
  Cc: Martin K . Petersen, linux-scsi, Kernel Janitors


Le 14/07/2021 à 21:48, Sasha Levin a écrit :
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> [ Upstream commit c7fa2c855e892721bafafdf6393342c000e0ef77 ]
>
> Fix a few style issues reported by checkpatch.pl:
>
>   - Avoid duplicated word in comment.
>
>   - Add missing space in messages.
>
>   - Unneeded continuation line character.
>
>   - Unneeded extra spaces.
>
>   - Unneeded log message after memory allocation failure.
>
> Link: https://lore.kernel.org/r/8cb62f0eb96ec7ce7a73fe97cb4490dd5121ecff.1623482155.git.christophe.jaillet@wanadoo.fr
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Hi,

I always appreciate to have some patches backported, but in this 
particular case, I wonder what is the rational to backport up to 4.9 
some checkpatch warning about log message?

Keeping code aligned to ease other future backport?

I thought that the rule for backport was that it needed to fix a real 
issue (and sometimes a real 'potential' issue)

CJ



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages
  2021-07-16 19:22   ` [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages Marion & Christophe JAILLET
@ 2021-07-21 10:42     ` Sasha Levin
  0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2021-07-21 10:42 UTC (permalink / raw)
  To: Marion & Christophe JAILLET
  Cc: linux-kernel, stable, Martin K . Petersen, linux-scsi, Kernel Janitors

On Fri, Jul 16, 2021 at 09:22:43PM +0200, Marion & Christophe JAILLET wrote:
>
>Le 14/07/2021 à 21:48, Sasha Levin a écrit :
>>From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>
>>[ Upstream commit c7fa2c855e892721bafafdf6393342c000e0ef77 ]
>>
>>Fix a few style issues reported by checkpatch.pl:
>>
>>  - Avoid duplicated word in comment.
>>
>>  - Add missing space in messages.
>>
>>  - Unneeded continuation line character.
>>
>>  - Unneeded extra spaces.
>>
>>  - Unneeded log message after memory allocation failure.
>>
>>Link: https://lore.kernel.org/r/8cb62f0eb96ec7ce7a73fe97cb4490dd5121ecff.1623482155.git.christophe.jaillet@wanadoo.fr
>>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>>Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Hi,
>
>I always appreciate to have some patches backported, but in this 
>particular case, I wonder what is the rational to backport up to 4.9 
>some checkpatch warning about log message?
>
>Keeping code aligned to ease other future backport?
>
>I thought that the rule for backport was that it needed to fix a real 
>issue (and sometimes a real 'potential' issue)

I think that I brought it in as a dependency for something else, but I
don't see what it was. I'll drop it then, thanks!

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-21 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210714194806.55962-1-sashal@kernel.org>
     [not found] ` <20210714194806.55962-17-sashal@kernel.org>
2021-07-16 19:22   ` [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages Marion & Christophe JAILLET
2021-07-21 10:42     ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).