* Re: [PATCH] media: camss: fix memory leaks on error handling paths in probe
@ 2020-07-23 19:51 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-07-23 19:51 UTC (permalink / raw)
To: Evgeny Novikov, Anton Vasilyev, ldv-project, linux-arm-msm, linux-media
Cc: kernel-janitors, linux-kernel, Andy Gross, Bjorn Andersson,
Mauro Carvalho Chehab, Todor Tomov
> camss_probe() does not free camss on error handling paths. The patch
> introduces an additional error label for this purpose.
* I suggest to use an imperative wording for the change description.
* Would you like to use also a jump target like the following
at the end of this function implementation?
+e_nomem:
+ ret = -ENOMEM;
+ goto err_free;
* Will the tag “Fixes” become helpful for the commit message?
> Besides, it
> removes call of v4l2_async_notifier_cleanup() from
> camss_of_parse_ports() since its caller, camss_probe(), cleans up all
> its resources itself.
I propose to offer such a change by a separate update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=d15be546031cf65a0fc34879beca02fd90fe7ac7#n138
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-23 19:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 19:51 [PATCH] media: camss: fix memory leaks on error handling paths in probe Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).