From: Heiko Schocher <hs@denx.de>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
Date: Sat, 19 Jun 2021 08:21:35 +0200 [thread overview]
Message-ID: <67e49b8b-a80c-87a0-c5bb-8d5cf9239328@denx.de> (raw)
In-Reply-To: <YMyir961W28TX5dT@mwanda>
Hello Dan,
On 18.06.21 15:42, Dan Carpenter wrote:
> Smatch complains that zero length read/writes will lead to an
> uninitalized return value. I don't know if that's possible, but
> it's nicer to return a zero literal anyway so let's do that.
>
> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> People, when we add a new driver can we make sure the first commit uses
> the new prefered subsystem prefix? For example,
>
> "mtd: mchp48l640: add support for microchip 48l640 EERAM"
> ^^^^^^^^^^
> Otherwise it's not clear to me what I should use as a patch prefix.
Ok, sorry...
Hmm... Colin already sent a fix for this, see:
https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
next prev parent reply other threads:[~2021-06-19 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 13:42 [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings Dan Carpenter
2021-06-19 6:21 ` Heiko Schocher [this message]
2021-06-22 15:31 ` Fabio Estevam
2021-06-22 15:39 ` Colin Ian King
2021-06-23 3:22 ` Heiko Schocher
2021-07-15 22:50 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e49b8b-a80c-87a0-c5bb-8d5cf9239328@denx.de \
--to=hs@denx.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).