archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Miquel Raynal <>
Cc: Richard Weinberger <>,
	Vignesh Raghavendra <>,
	Heiko Schocher <>,,
Subject: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
Date: Fri, 18 Jun 2021 16:42:07 +0300	[thread overview]
Message-ID: <YMyir961W28TX5dT@mwanda> (raw)

Smatch complains that zero length read/writes will lead to an
uninitalized return value.  I don't know if that's possible, but
it's nicer to return a zero literal anyway so let's do that.

Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
Signed-off-by: Dan Carpenter <>
People, when we add a new driver can we make sure the first commit uses
the new prefered subsystem prefix?  For example,

"mtd: mchp48l640: add support for microchip 48l640 EERAM"
Otherwise it's not clear to me what I should use as a patch prefix.

 drivers/mtd/devices/mchp48l640.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/mchp48l640.c b/drivers/mtd/devices/mchp48l640.c
index efc2003bd13a..ad66b5aaf4e9 100644
--- a/drivers/mtd/devices/mchp48l640.c
+++ b/drivers/mtd/devices/mchp48l640.c
@@ -229,7 +229,7 @@ static int mchp48l640_write(struct mtd_info *mtd, loff_t to, size_t len,
 		woff += ws;
-	return ret;
+	return 0;
 static int mchp48l640_read_page(struct mtd_info *mtd, loff_t from, size_t len,
@@ -286,7 +286,7 @@ static int mchp48l640_read(struct mtd_info *mtd, loff_t from, size_t len,
 		woff += ws;
-	return ret;
+	return 0;
 static const struct mchp48_caps mchp48l640_caps = {

             reply	other threads:[~2021-06-18 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 13:42 Dan Carpenter [this message]
2021-06-19  6:21 ` [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings Heiko Schocher
2021-06-22 15:31   ` Fabio Estevam
2021-06-22 15:39     ` Colin Ian King
2021-06-23  3:22       ` Heiko Schocher
2021-07-15 22:50 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMyir961W28TX5dT@mwanda \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).